This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
add metrics acceptance question info #537
Merged
kaduartur
merged 6 commits into
ZupIT:master
from
victor-schumacher:feature/metricsAcceptance
Sep 22, 2020
Merged
add metrics acceptance question info #537
kaduartur
merged 6 commits into
ZupIT:master
from
victor-schumacher:feature/metricsAcceptance
Sep 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
- Coverage 78.80% 78.21% -0.60%
==========================================
Files 97 96 -1
Lines 3176 3089 -87
==========================================
- Hits 2503 2416 -87
+ Misses 496 493 -3
- Partials 177 180 +3
Continue to review full report at Codecov.
|
victor-schumacher
added
🔨 improvement
Improvement in features
✔️ ready-for-review
ready for review
labels
Sep 18, 2020
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
lucasdittrichzup
previously approved these changes
Sep 21, 2020
kaduartur
suggested changes
Sep 21, 2020
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
kaduartur
suggested changes
Sep 21, 2020
brunasilvazup
approved these changes
Sep 22, 2020
kaduartur
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
added metrics acceptance question info
- How to verify it
Check metabase or log the struct
- Description for the changelog
added metrics acceptance question info