Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

add metrics acceptance question info #537

Merged
merged 6 commits into from
Sep 22, 2020
Merged

add metrics acceptance question info #537

merged 6 commits into from
Sep 22, 2020

Conversation

victor-schumacher
Copy link
Contributor

- What I did
added metrics acceptance question info

- How to verify it
Check metabase or log the struct

- Description for the changelog
added metrics acceptance question info

Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #537 into master will decrease coverage by 0.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   78.80%   78.21%   -0.60%     
==========================================
  Files          97       96       -1     
  Lines        3176     3089      -87     
==========================================
- Hits         2503     2416      -87     
+ Misses        496      493       -3     
- Partials      177      180       +3     
Impacted Files Coverage Δ
pkg/metric/metric.go 100.00% <ø> (ø)
pkg/cmd/init.go 100.00% <100.00%> (ø)
pkg/formula/builder/local.go 70.21% <0.00%> (-17.79%) ⬇️
pkg/formula/builder/docker.go 73.91% <0.00%> (-12.93%) ⬇️
pkg/formula/builder/make.go 88.88% <0.00%> (-11.12%) ⬇️
pkg/formula/runner/docker/runner.go 90.00% <0.00%> (-4.00%) ⬇️
pkg/formula/runner/local/pre_run.go 93.10% <0.00%> (-1.35%) ⬇️
pkg/formula/builder/bat.go 0.00% <0.00%> (ø)
pkg/formula/builder/shell.go
pkg/formula/formula.go 85.71% <0.00%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c07c3...9e9049c. Read the comment docs.

@victor-schumacher victor-schumacher self-assigned this Sep 18, 2020
@victor-schumacher victor-schumacher added 🔨 improvement Improvement in features ✔️ ready-for-review ready for review labels Sep 18, 2020
@victor-schumacher victor-schumacher mentioned this pull request Sep 18, 2020
5 tasks
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@kaduartur kaduartur added 🕒 Wait and removed ✔️ ready-for-review ready for review labels Sep 21, 2020
pkg/cmd/init.go Outdated Show resolved Hide resolved
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
pkg/cmd/init.go Show resolved Hide resolved
Copy link
Contributor

@kaduartur kaduartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaduartur kaduartur merged commit 8a23623 into ZupIT:master Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 improvement Improvement in features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants