Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add defer to PostRun function #548

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Add defer to PostRun function #548

merged 2 commits into from
Sep 23, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did
I added a defer statement to PostRun

- How to verify it
Run a formula and check the .rit folder, thetmp directory must not exist!

- Description for the changelog
Remove tmp directory to not fill the user's disk

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
@kaduartur kaduartur added 🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review labels Sep 22, 2020
@kaduartur kaduartur self-assigned this Sep 22, 2020
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #548 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   78.54%   78.58%   +0.03%     
==========================================
  Files          98       98              
  Lines        3179     3184       +5     
==========================================
+ Hits         2497     2502       +5     
  Misses        498      498              
  Partials      184      184              
Impacted Files Coverage Δ
pkg/formula/runner/docker/runner.go 92.30% <100.00%> (+0.30%) ⬆️
pkg/formula/runner/local/runner.go 94.59% <100.00%> (+0.30%) ⬆️
pkg/formula/runner/post_run.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a23623...b5436c2. Read the comment docs.

Copy link
Contributor

@brunasilvazup brunasilvazup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Sep 23, 2020

👌 Merged branch fix/remove_tmp_dir into qa

@kaduartur kaduartur added 🚀 QA and removed ✔️ ready-for-review ready for review labels Sep 23, 2020
@kaduartur kaduartur merged commit f6dad3e into ZupIT:master Sep 23, 2020
@kaduartur kaduartur deleted the fix/remove_tmp_dir branch September 23, 2020 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug Report a bug encountered while operating Ritchie
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check why the formula's tmp folder is not deleted when formula execution fails
4 participants