Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add sending metrics for the --watch flag #563

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Add sending metrics for the --watch flag #563

merged 2 commits into from
Sep 30, 2020

Conversation

dittrichlucas
Copy link
Contributor

- What I did

  • Added sending metrics for the --watch flag

- How to verify it

  • Access the metrics dashboard

- Description for the changelog

  • add sending metrics for the --watch flag

@dittrichlucas
[fix] add sending metrics for the --watch flag
f55b276 
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
@lucasdittrichzup lucasdittrichzup added 🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review labels Sep 28, 2020
@lucasdittrichzup lucasdittrichzup added this to the 2.1.0 milestone Sep 28, 2020
@lucasdittrichzup lucasdittrichzup linked an issue Sep 28, 2020 that may be closed by this pull request
flag --watch doesn't send metrics #542
Closed
@dittrichlucas
[fix] fix lint
c4c524f 
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #563 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
+ Coverage   78.67%   78.72%   +0.04%     
==========================================
  Files          98       98              
  Lines        3189     3196       +7     
==========================================
+ Hits         2509     2516       +7     
  Misses        496      496              
  Partials      184      184
Impacted Files Coverage Δ
pkg/formula/watcher/watcher.go 78.37% <100.00%> (+5.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa5cd6...c4c524f. Read the comment docs.

@lucasdittrichzup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Sep 30, 2020

👌 Merged branch fix/send-metric-flag-watch into qa

@lucasdittrichzup lucasdittrichzup added 🚀 QA and removed ✔️ ready-for-review ready for review labels Sep 30, 2020
@lucasdittrichzup lucasdittrichzup self-requested a review September 30, 2020 12:55
@lucasdittrichzup lucasdittrichzup merged commit 53c41fb into ZupIT:master Sep 30, 2020
@dittrichlucas dittrichlucas deleted the fix/send-metric-flag-watch branch October 26, 2020 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brunasilvazup brunasilvazup brunasilvazup approved these changes

@victor-schumacher victor-schumacher victor-schumacher approved these changes

@kaduartur kaduartur Awaiting requested review from kaduartur

@lucasdittrichzup lucasdittrichzup Awaiting requested review from lucasdittrichzup

Assignees

@dittrichlucas dittrichlucas

@lucasdittrichzup lucasdittrichzup

Labels
🪲 bug Report a bug encountered while operating Ritchie
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

flag --watch doesn't send metrics
5 participants
@dittrichlucas @codecov-commenter @lucasdittrichzup @victor-schumacher @brunasilvazup