This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Fixing windows installer and logo #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kadu Artur Prussek <kadu.prussek@zup.com.br>
Signed-off-by: Kadu Artur Prussek <kadu.prussek@zup.com.br>
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
…s/ritchie-cli into feat/add-info-build-formula
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
…s/ritchie-cli into feat/add-info-build-formula
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
Signed-off-by: Lucas Dittrich <ld.dittrich@gmail.com>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 80.06% 80.15% +0.08%
==========================================
Files 98 98
Lines 3196 3199 +3
==========================================
+ Hits 2559 2564 +5
+ Misses 448 446 -2
Partials 189 189
Continue to review full report at Codecov.
|
henriquemoraeszup
added
the
🪲 bug
henriquemoraeszup
added
✔️ ready-for-review
lucasdittrichzup
previously approved these changes
Oct 1, 2020
|
/merge qa |
|
🔥 Merge Conflict |
…-installer Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # docs/img/ritchie-banner.bmp # packaging/windows/ritchie-wix-templates/product.wxs
|
/merge qa |
1 similar comment
|
/merge qa |
|
👌 Merged branch hm/fix-windows-installer into qa |
victor-schumacher
previously approved these changes
Oct 2, 2020
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
|
/merge qa |
1 similar comment
|
/merge qa |
|
please? |
|
/merge qa |
|
👌 Merged branch hm/fix-windows-installer into qa |
victor-schumacher
approved these changes
Oct 2, 2020
lucasdittrichzup
approved these changes
Oct 2, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henrique Moraes henrique.moraes@zup.com.br
- What I did
Created a branch based on #555 and fixed the logo layout. The PR also contemplates a fix on the uninstall option of the installer
Download the QA version.
Install Ritchie in another path and try to remove this with the Windows **uninstall or change a program **
Edit Windows installer template