-
Notifications
You must be signed in to change notification settings - Fork 102
[Fix] - Searching only for run.sh on docker pre run #598
[Fix] - Searching only for run.sh on docker pre run #598
Conversation
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
- Coverage 80.34% 79.83% -0.51%
==========================================
Files 98 98
Lines 3287 3219 -68
==========================================
- Hits 2641 2570 -71
- Misses 462 465 +3
Partials 184 184
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoaoDanielRufino this change its necessary only in windows? If yes, would it be good to specify windows situation in the code?
PS.: I used 'request changes' to discuss this before, not necessarily needs changes.
We talked and I could understand that it is just a check for windows. |
/merge qa |
👌 Merged branch fix/docker-pre-run into qa |
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
Signed-off-by: JoaoDanielRufino joaodaniel0405@gmail.com
- What I did
When building a formula with docker on windows, the CLI only checks if there is a run.bat file, but on docker it is necessary to check if there is a run.sh file to build the formula.
- How to verify it
Build a formula locally on windows and then run the formula with docker.
- Description for the changelog
Check if there is run.sh file when building formula with docker.