This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Decoupling build commands from main #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
lucasdittrichzup
previously approved these changes
Oct 22, 2020
|
🚀 |
victorschumacherzup
previously approved these changes
Oct 23, 2020
GuillaumeFalourd
previously approved these changes
Oct 23, 2020
brunasilvazup
added
🔨 improvement
…ouple Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # cmd/main.go
henriquemoraeszup
dismissed stale reviews from GuillaumeFalourd, victorschumacherzup, lucasdittrichzup, brunasilvazup, and kaduartur
via
0d971ee
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
=======================================
Coverage 80.71% 80.71%
=======================================
Files 101 101
Lines 3547 3547
=======================================
Hits 2863 2863
Misses 491 491
Partials 193 193 Continue to review full report at Codecov.
|
victor-schumacher
approved these changes
Oct 26, 2020
victorschumacherzup
approved these changes
Oct 26, 2020
henriquemoraeszup
added a commit
that referenced
this pull request
Nov 9, 2020
* Add file Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Remove one of linters Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Update ci Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More disables Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Disable one linter, fix code Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More improvements Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix errors Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More improvements Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Update ci Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Improve linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * goftm Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix some gocritic issues Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversation * Improvement pipeline (#614) * adding stg environment * adding stg environment Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * Trying to make DCO pass Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * adding stg environment (#606) * adding stg environment * adding stg environment Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * Trying to make DCO pass Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * refactoring pipeline * minor tweaks * removing unnecessary files * adding routing script Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * added context printing (#632) * added context printing Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * fix extra spaces, showling only non default contexts now Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Prompt to auto rebuild formula on source modifications (#578) * Prompting to rebuild on modifications Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Go style to pre run builder Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Running pre build for local repo only Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding more pre run build tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Refactor: Extracting workspace hashing to workspace.go Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Updating formula hash on manual builds Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding workspace hash tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Customizing workspace hashing custom mock methods Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Organizing pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Removing dead code Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Organizing pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Hashing the whole formula instead of only the src Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Decoupling build commands from main (#630) * Decoupling build commands from main Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> * Linter Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * added warning on same env name (#633) * added warning and test case Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * remove print' Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * new function for check Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Merge master Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Disable maligned Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix ci * Check for errors * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix errors after merge Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> Co-authored-by: viniciusramosdefaria <viniciusramosdefaria@gmail.com> Co-authored-by: Victor Schumacher <51962831+victorschumacherzup@users.noreply.github.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: gabriel-pinheiro <56726395+gabriel-pinheiro@users.noreply.github.com> Co-authored-by: henriquemoraeszup <68074718+henriquemoraeszup@users.noreply.github.com>
brunonmelo
pushed a commit
to brunonmelo/ritchie-cli
that referenced
this pull request
Nov 12, 2020
* Decoupling build commands from main Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> * Linter Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
brunonmelo
pushed a commit
to brunonmelo/ritchie-cli
that referenced
this pull request
Nov 12, 2020
* Add file Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Remove one of linters Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Update ci Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More disables Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Disable one linter, fix code Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More improvements Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix errors Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More improvements Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Update ci Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Improve linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * goftm Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix some gocritic issues Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversation * Improvement pipeline (ZupIT#614) * adding stg environment * adding stg environment Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * Trying to make DCO pass Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * adding stg environment (ZupIT#606) * adding stg environment * adding stg environment Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * Trying to make DCO pass Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * refactoring pipeline * minor tweaks * removing unnecessary files * adding routing script Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * added context printing (ZupIT#632) * added context printing Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * fix extra spaces, showling only non default contexts now Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Prompt to auto rebuild formula on source modifications (ZupIT#578) * Prompting to rebuild on modifications Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Go style to pre run builder Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Running pre build for local repo only Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding more pre run build tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Refactor: Extracting workspace hashing to workspace.go Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Updating formula hash on manual builds Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding workspace hash tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Customizing workspace hashing custom mock methods Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Organizing pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Removing dead code Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Organizing pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Hashing the whole formula instead of only the src Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Decoupling build commands from main (ZupIT#630) * Decoupling build commands from main Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> * Linter Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * added warning on same env name (ZupIT#633) * added warning and test case Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * remove print' Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * new function for check Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Merge master Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Disable maligned Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix ci * Check for errors * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix errors after merge Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> Co-authored-by: viniciusramosdefaria <viniciusramosdefaria@gmail.com> Co-authored-by: Victor Schumacher <51962831+victorschumacherzup@users.noreply.github.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: gabriel-pinheiro <56726395+gabriel-pinheiro@users.noreply.github.com> Co-authored-by: henriquemoraeszup <68074718+henriquemoraeszup@users.noreply.github.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
brunonmelo
pushed a commit
to brunonmelo/ritchie-cli
that referenced
this pull request
Nov 12, 2020
* Decoupling build commands from main Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> * Linter Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
brunonmelo
pushed a commit
to brunonmelo/ritchie-cli
that referenced
this pull request
Nov 12, 2020
* Add file Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Remove one of linters Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Update ci Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More disables Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Disable one linter, fix code Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More improvements Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix errors Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More improvements Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Update ci Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Improve linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * goftm Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix some gocritic issues Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversation * Improvement pipeline (ZupIT#614) * adding stg environment * adding stg environment Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * Trying to make DCO pass Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * adding stg environment (ZupIT#606) * adding stg environment * adding stg environment Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * Trying to make DCO pass Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * refactoring pipeline * minor tweaks * removing unnecessary files * adding routing script Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * added context printing (ZupIT#632) * added context printing Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * fix extra spaces, showling only non default contexts now Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Prompt to auto rebuild formula on source modifications (ZupIT#578) * Prompting to rebuild on modifications Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Go style to pre run builder Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Running pre build for local repo only Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding more pre run build tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Refactor: Extracting workspace hashing to workspace.go Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Updating formula hash on manual builds Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding workspace hash tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Customizing workspace hashing custom mock methods Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Organizing pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Removing dead code Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Organizing pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Hashing the whole formula instead of only the src Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Decoupling build commands from main (ZupIT#630) * Decoupling build commands from main Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> * Linter Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * added warning on same env name (ZupIT#633) * added warning and test case Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * remove print' Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * new function for check Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Merge master Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Disable maligned Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix ci * Check for errors * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix errors after merge Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> Co-authored-by: viniciusramosdefaria <viniciusramosdefaria@gmail.com> Co-authored-by: Victor Schumacher <51962831+victorschumacherzup@users.noreply.github.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: gabriel-pinheiro <56726395+gabriel-pinheiro@users.noreply.github.com> Co-authored-by: henriquemoraeszup <68074718+henriquemoraeszup@users.noreply.github.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henrique Moraes henrique.moraes@zup.com.br
Description
We are going to develop an enterprise version of the cli for the cloud. The chosen architecture is to import the open source cli as a package on the proprietary repo. Since we cannot import commands from
main, we need to decouple thebuildCommandsmethod into its own packageHow to verify it
Run Ritchie and check it still works
Changelog
Decoupled build commands from main