This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Remove repository version check #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
kaduartur
added
priority:high
kaduartur
requested review from
brunasilvazup,
henriquemoraeszup,
lucasdittrichzup,
rodrigomedeirosf and
victorschumacherzup
as code owners
lucasdittrichzup
previously approved these changes
Nov 6, 2020
brunasilvazup
previously approved these changes
Nov 6, 2020
henriquemoraeszup
previously approved these changes
Nov 6, 2020
kaduartur
dismissed stale reviews from henriquemoraeszup, brunasilvazup, and lucasdittrichzup
via
19674b0
kaduartur
requested review from
victorschumacherzup,
brunasilvazup,
lucasdittrichzup and
henriquemoraeszup
henriquemoraeszup
approved these changes
Nov 6, 2020
|
/merge qa |
|
👌 Merged branch feature/version_check into qa |
brunonmelo
pushed a commit
to brunonmelo/ritchie-cli
that referenced
this pull request
Nov 12, 2020
* remove repository version check in merge tree method Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Add nolint to getLatestTag Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
brunonmelo
pushed a commit
to brunonmelo/ritchie-cli
that referenced
this pull request
Nov 12, 2020
* remove repository version check in merge tree method Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Add nolint to getLatestTag Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When carrying out the construction of the command tree, we make requests to check the latest version of each formula repository, but this has been showing crashes in the user terminal with slow internet. We commented on this part of the code to do a better analysis and create a more robust solution to this problem.
Before:
After:
How to verify it
Now you cannot see the new repositories version when executing the rit command
Changelog
Removed repository version check