This repository was archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
Add testify to project #686
Merged
brunasilvazup
merged 7 commits into
ZupIT:master
from
brunasilvazup:improvement/add-lib-testify
Nov 23, 2020
Merged
Add testify to project #686
brunasilvazup
merged 7 commits into
ZupIT:master
from
brunasilvazup:improvement/add-lib-testify
Nov 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
=======================================
Coverage 80.76% 80.76%
=======================================
Files 108 108
Lines 3702 3702
=======================================
Hits 2990 2990
Misses 516 516
Partials 196 196 Continue to review full report at Codecov.
|
victorschumacherzup
previously approved these changes
Nov 20, 2020
noice 🔝 |
kaduartur
suggested changes
Nov 20, 2020
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
henriquemoraeszup
approved these changes
Nov 23, 2020
kaduartur
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge qa |
👌 Merged branch improvement/add-lib-testify into qa |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add testify to project and using in tests of
setter.go
.How to verify it
Check the vendor and check the tests.
Changelog
Add testify to project