Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

Add testify to project #686

Merged
merged 7 commits into from
Nov 23, 2020

Conversation

brunasilvazup
Copy link
Contributor

@brunasilvazup brunasilvazup commented Nov 19, 2020

Description

Add testify to project and using in tests of setter.go.

How to verify it

Check the vendor and check the tests.

Changelog

Add testify to project

Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
@brunasilvazup brunasilvazup added the 🔨 improvement Improvement in features label Nov 19, 2020
@brunasilvazup brunasilvazup self-assigned this Nov 19, 2020
@brunasilvazup brunasilvazup added the 🚧 WIP Work in Progress label Nov 19, 2020
@brunasilvazup brunasilvazup changed the title Add testify Add testify to project Nov 20, 2020
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
@brunasilvazup brunasilvazup added ✔️ ready-for-review ready for review and removed 🚧 WIP Work in Progress labels Nov 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #686 (c216003) into master (89185a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files         108      108           
  Lines        3702     3702           
=======================================
  Hits         2990     2990           
  Misses        516      516           
  Partials      196      196           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89185a5...c216003. Read the comment docs.

@victorschumacherzup
Copy link
Contributor

noice 🔝

Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Copy link
Contributor

@kaduartur kaduartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brunasilvazup
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Nov 23, 2020

👌 Merged branch improvement/add-lib-testify into qa

@brunasilvazup brunasilvazup merged commit 1df9759 into ZupIT:master Nov 23, 2020
@brunasilvazup brunasilvazup mentioned this pull request Nov 23, 2020
2 tasks
@brunasilvazup brunasilvazup linked an issue Nov 23, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 improvement Improvement in features ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the testify library to ritchie
5 participants