Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

fix: add check for variables with the same name #693

Merged

Conversation

lucasdittrichzup
Copy link
Contributor

Description

A check has been added in case config.json contains inputs with the same name.

In addition, the default help for flags was removed, because when there are inputs with the same name and they have items, the help was incoherent.

gif containing the command demonstration

Fix #665

How to verify it

  1. Make sure you have a form with inputs with the same name
  2. Build the formula
  3. Run the formula and verify that Ritchie continues to work

Changelog

Add check for variables with the same name

Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup lucasdittrichzup added 🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review labels Nov 24, 2020
@lucasdittrichzup lucasdittrichzup added this to the 2.5.0 milestone Nov 24, 2020
@lucasdittrichzup lucasdittrichzup self-assigned this Nov 24, 2020
Copy link
Contributor

@henriquemoraeszup henriquemoraeszup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be missing a test for this case

brunasilvazup
brunasilvazup previously approved these changes Nov 24, 2020
Copy link
Contributor

@brunasilvazup brunasilvazup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's excellent solution, congrats 🥇

Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Nov 27, 2020

👌 Merged branch fix/duplicate-variable-name into qa

@lucasdittrichzup
Copy link
Contributor Author

it's working on Linux and Windows

@lucasdittrichzup lucasdittrichzup merged commit 13275a3 into ZupIT:master Nov 27, 2020
@lucasdittrichzup lucasdittrichzup deleted the fix/duplicate-variable-name branch July 21, 2021 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with existing config.json variable name with upgrade to 2.3.0
3 participants