This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
fix: add check for variables with the same name #693
Merged
lucasdittrichzup
merged 2 commits into
ZupIT:master
from
lucasdittrichzup:fix/duplicate-variable-name
Nov 27, 2020
Merged
fix: add check for variables with the same name #693
lucasdittrichzup
merged 2 commits into
ZupIT:master
from
lucasdittrichzup:fix/duplicate-variable-name
Nov 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
lucasdittrichzup
added
🪲 bug
Report a bug encountered while operating Ritchie
✔️ ready-for-review
ready for review
labels
Nov 24, 2020
lucasdittrichzup
requested review from
kaduartur,
victorschumacherzup,
brunasilvazup and
henriquemoraeszup
November 24, 2020 19:38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be missing a test for this case
brunasilvazup
previously approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's excellent solution, congrats 🥇
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
brunasilvazup
approved these changes
Nov 25, 2020
henriquemoraeszup
approved these changes
Nov 25, 2020
/merge qa |
👌 Merged branch fix/duplicate-variable-name into qa |
it's working on Linux and Windows |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A check has been added in case config.json contains inputs with the same name.
In addition, the default help for flags was removed, because when there are inputs with the same name and they have items, the help was incoherent.
Fix #665
How to verify it
Changelog
Add check for variables with the same name