Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Conversation

brunasilvazup
Copy link
Contributor

@brunasilvazup brunasilvazup commented Dec 1, 2020

Description

This PR add a verification in rit add repo (stdin and prompt) to verify if the formula repo has already been added.

  • This verification happens after receiving the url and the version.

Prompt
image

Stdin
image

Other version, don't presents error
image

How to verify it

Clone this PR and add a repo existent, (commons repo for example).

Changelog

Add step to verify repo existence

Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
@brunasilvazup brunasilvazup added 🔨 improvement Improvement in features 🚧 WIP Work in Progress labels Dec 1, 2020
@brunasilvazup brunasilvazup self-assigned this Dec 1, 2020
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
@brunasilvazup brunasilvazup linked an issue Dec 3, 2020 that may be closed by this pull request
@brunasilvazup brunasilvazup marked this pull request as ready for review December 3, 2020 22:26
@brunasilvazup brunasilvazup added ✔️ ready-for-review ready for review and removed 🚧 WIP Work in Progress labels Dec 3, 2020
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
@brunasilvazup brunasilvazup added 🚧 WIP Work in Progress and removed ✔️ ready-for-review ready for review labels Dec 11, 2020
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
…provement/add-message-if-user-tries-to-add-existing-repository

Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
…provement/add-message-if-user-tries-to-add-existing-repository

Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
@ZupIT ZupIT deleted a comment from codecov-io Dec 14, 2020
@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #704 (d5e6772) into master (36c6a39) will increase coverage by 0.12%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   82.45%   82.57%   +0.12%     
==========================================
  Files         110      110              
  Lines        3755     3765      +10     
==========================================
+ Hits         3096     3109      +13     
+ Misses        479      472       -7     
- Partials      180      184       +4     
Impacted Files Coverage Δ
pkg/cmd/add_repo.go 84.09% <70.00%> (+3.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c6a39...d5e6772. Read the comment docs.

Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
@henriquemoraeszup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Dec 14, 2020

🔥 Merge Conflict

…provement/add-message-if-user-tries-to-add-existing-repository

Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
…provement/add-message-if-user-tries-to-add-existing-repository

Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
@henriquemoraeszup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Dec 14, 2020

👌 Merged branch improvement/add-message-if-user-tries-to-add-existing-repository into qa

@henriquemoraeszup henriquemoraeszup merged commit 095d94a into ZupIT:master Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 improvement Improvement in features ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests with Testify in Add Repo Prevent users from adding the same repo again
6 participants