This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
Add step to verify repo existence #704
Merged
henriquemoraeszup
merged 27 commits into
ZupIT:master
from
brunasilvazup:improvement/add-message-if-user-tries-to-add-existing-repository
Dec 14, 2020
Merged
Add step to verify repo existence #704
henriquemoraeszup
merged 27 commits into
ZupIT:master
from
brunasilvazup:improvement/add-message-if-user-tries-to-add-existing-repository
Dec 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
brunasilvazup
requested review from
henriquemoraeszup,
kaduartur,
lucasdittrichzup,
rodrigomedeirosf and
victorschumacherzup
as code owners
December 3, 2020 22:26
brunasilvazup
added
✔️ ready-for-review
ready for review
and removed
🚧 WIP
Work in Progress
labels
Dec 3, 2020
lucasdittrichzup
previously approved these changes
Dec 4, 2020
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
brunasilvazup
added
🚧 WIP
Work in Progress
and removed
✔️ ready-for-review
ready for review
labels
Dec 7, 2020
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
victorschumacherzup
previously approved these changes
Dec 9, 2020
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
brunasilvazup
dismissed stale reviews from victorschumacherzup and victor-schumacher
via
December 10, 2020 20:14
38969dd
brunasilvazup
added
🚧 WIP
Work in Progress
and removed
✔️ ready-for-review
ready for review
labels
Dec 11, 2020
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
…provement/add-message-if-user-tries-to-add-existing-repository Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
…provement/add-message-if-user-tries-to-add-existing-repository Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 82.45% 82.57% +0.12%
==========================================
Files 110 110
Lines 3755 3765 +10
==========================================
+ Hits 3096 3109 +13
+ Misses 479 472 -7
- Partials 180 184 +4
Continue to review full report at Codecov.
|
Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
brunasilvazup
requested review from
victorschumacherzup and
henriquemoraeszup
December 14, 2020 17:20
henriquemoraeszup
previously approved these changes
Dec 14, 2020
/merge qa |
🔥 Merge Conflict |
…provement/add-message-if-user-tries-to-add-existing-repository Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
…provement/add-message-if-user-tries-to-add-existing-repository Signed-off-by: Bruna Tavares <bruna.silva@zup.com.br>
/merge qa |
👌 Merged branch improvement/add-message-if-user-tries-to-add-existing-repository into qa |
henriquemoraeszup
approved these changes
Dec 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a verification in
rit add repo
(stdin and prompt) to verify if the formula repo has already been added.How to verify it
Clone this PR and add a repo existent, (commons repo for example).
Changelog
Add step to verify repo existence