This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Improve performance to "rit create formula" command #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
kaduartur
added
🔨 improvement
kaduartur
requested review from
brunasilvazup,
henriquemoraeszup,
lucasdittrichzup,
rodrigomedeirosf and
victorschumacherzup
as code owners
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
brunasilvazup
previously approved these changes
Dec 18, 2020
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 82.52% 83.80% +1.27%
==========================================
Files 110 110
Lines 3806 3797 -9
==========================================
+ Hits 3141 3182 +41
+ Misses 481 440 -41
+ Partials 184 175 -9
Continue to review full report at Codecov.
|
henriquemoraeszup
approved these changes
Dec 21, 2020
34 tasks
|
/merge qa |
|
🔥 Merge Conflict |
|
/merge qa |
|
👌 Merged branch performance/create_formula_loading into qa |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some versions ago we removed the building code of the
rit create formulacommand because it is already present at the time of executing a formula, then we realized that we could remove the spinner of therit create formulacommand. The command now executes instantly when called.When creating the formula we now generate your hash to get to know if we had any changes to the formula before the first build was done.
How to verify it
Follow the steps below:
The formula changes must be present in the first build.
Changelog
Remove spinner from
rit create formula