-
Notifications
You must be signed in to change notification settings - Fork 102
Conversation
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
==========================================
+ Coverage 82.52% 82.63% +0.10%
==========================================
Files 110 110
Lines 3806 3806
==========================================
+ Hits 3141 3145 +4
+ Misses 481 479 -2
+ Partials 184 182 -2
Continue to review full report at Codecov.
|
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the sliceutil/
package inside the slice/
so we don't have "util" packages lost inside pkg/
, this is a very common pattern in Golang. An example is the ioutil package.
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the approach of removing functions that are specific to their respective packages! 🚀
/merge qa |
👌 Merged branch hm/tests-on-slice into qa |
Description
There were some changes on this PR besides adding testify. Some of the methods from the utils package were used in a single file. Such methods were moved to their respective files. Also to avoid folder nesting,
slice_util.go
was moved up one folderHow to verify it
Run slice tests and check if they pass
Changelog
Test refactor on slice util