created rit add workspace command #809

aronrichter · 2020-12-19T21:58:35Z

Description

As requested on #802, is necessary a command do add a new workspace.

How to verify it

You can run the command rit add workspace and after you can run rit list workspace and then you can see your workspace added

Changelog

Added a new core command rit add workspace

henriquemoraeszup

Thanks for your contribution aron! Just a couple of points below, keep it up 💪

pkg/cmd/add_workspace.go

pkg/cmd/add_workspace_test.go

codecov-io · 2020-12-19T23:59:48Z

Codecov Report

Merging #809 (91d57e0) into master (84b0008) will decrease coverage by 0.02%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
- Coverage   83.80%   83.77%   -0.03%     
==========================================
  Files         110      111       +1     
  Lines        3797     3840      +43     
==========================================
+ Hits         3182     3217      +35     
- Misses        440      444       +4     
- Partials      175      179       +4

Impacted Files	Coverage Δ
pkg/cmd/add_workspace.go	`85.71% <85.71%> (ø)`
pkg/commands/builder.go	`90.25% <100.00%> (+0.05%)`	⬆️
pkg/slice/sliceutil/slice_util.go	`83.33% <0.00%> (-16.67%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b0008...91d57e0. Read the comment docs.

pkg/cmd/add_workspace.go

pkg/cmd/add_workspace_test.go

henriquemoraeszup · 2020-12-21T11:37:55Z

pkg/cmd/add_workspace.go

+	workspaceName, _ := cmd.Flags().GetString(workspaceNameFlag)
+	workspacePath, _ := cmd.Flags().GetString(workspacePathFlag)
+
+	if len(workspaceName) == 0 && len(workspacePath) == 0 {
+		return formula.Workspace{}, nil, false
+	}


what happens if you do rit add workspace --name= --path=?

It was the same thing when you don't pass any flag.
But, I understood why you'd ask, so I changed to check the number of flags passed before I decided what to do.

henriquemoraeszup · 2020-12-21T12:06:37Z

pkg/cmd/add_workspace_test.go

+		wantErr               string
+	}{
+		{
+			name:                  "add new workspace by prompt",


One detail, on a success case, you want to check if the workspace entry was actually added to ~/.rit/formula_workspaces.json so maybe you do not want to mock the workspace added

I'm not sure if I wanted to check that.
My unit it's until I called the method a.workspace.Add(wspace) after that the behavior ins't responsability of this method. Because of this I mocked my test.
What do you think?!

I do agree with you, lately we have been trying to adopt a more functional-like approach on our tests. But your argument is good as well, if you intend to continue with the mock, then maybe it is best to test that it has been called with the right arguments to ensure a thorough test. Check out assertCalled
https://godoc.org/github.com/stretchr/testify/mock#Mock.AssertCalled

That's right, I can mock my test, but at least a need to guarantee I'm passing the right parameters.
Thanks for the observation! 😄

henriquemoraeszup

Just one last suggestion on the mock but I am good to go. Just not approving now because any further commit would dismiss my review

henriquemoraeszup · 2020-12-21T23:27:08Z

pkg/cmd/add_workspace_test.go

+			}
+
+			workspaceMock := &mocks.WorkspaceMock{}
+			workspaceMock.On("Add", wspace).Return(tt.addWorkspaceWithError)


nice, this is even better than what I suggested 😄 will be recommending this to the team

henriquemoraeszup

👏 👏 👏 👏

kaduartur

Good job 🚀

You just needed to add this command to the core command list, you can add it in the api.go file. we use this to generate our autocomplete of the core commands.

kaduartur · 2020-12-22T21:15:18Z

pkg/cmd/add_workspace.go

+
+type addWorkspaceCmd struct {
+	workspace formula.WorkspaceAddLister
+	inText    prompt.InputText


could you rename this to input to make it more readable?

kaduartur · 2020-12-22T21:17:04Z

pkg/cmd/add_workspace.go

+
+func (a addWorkspaceCmd) runFormula() CommandRunnerFunc {
+	return func(cmd *cobra.Command, args []string) error {
+		if count := cmd.Flags().NFlag(); count == 0 {


could you simplify it to cmd.Flags().NFlag() == 0?

Signed-off-by: Aron Richter <aronrichter@gmail.com>

kaduartur

LGTM 🥇

kaduartur · 2020-12-23T15:44:46Z

/merge qa

ritchie-bot · 2020-12-23T15:45:06Z

🔥 Merge Conflict

kaduartur · 2020-12-23T15:53:25Z

/merge qa

ritchie-bot · 2020-12-23T15:53:29Z

👌 Merged branch feature/add-workspace into qa

aronrichter requested review from brunasilvazup, henriquemoraeszup, kaduartur, lucasdittrichzup, rodrigomedeirosf and victorschumacherzup as code owners December 19, 2020 21:58

henriquemoraeszup reviewed Dec 19, 2020

View reviewed changes

pkg/cmd/add_workspace.go Show resolved Hide resolved

pkg/cmd/add_workspace_test.go Outdated Show resolved Hide resolved

henriquemoraeszup assigned aronrichter Dec 19, 2020

aronrichter requested a review from henriquemoraeszup December 20, 2020 00:40

henriquemoraeszup added the ✨ feature Suggest a new feature or enhancement to the Ritchie project label Dec 20, 2020

henriquemoraeszup reviewed Dec 20, 2020

View reviewed changes

pkg/cmd/add_workspace.go Outdated Show resolved Hide resolved

henriquemoraeszup reviewed Dec 20, 2020

View reviewed changes

pkg/cmd/add_workspace.go Outdated Show resolved Hide resolved

henriquemoraeszup reviewed Dec 20, 2020

View reviewed changes

pkg/cmd/add_workspace_test.go Show resolved Hide resolved

henriquemoraeszup added this to the Community milestone Dec 20, 2020

aronrichter requested a review from henriquemoraeszup December 20, 2020 17:22

henriquemoraeszup reviewed Dec 21, 2020

View reviewed changes

henriquemoraeszup linked an issue Dec 21, 2020 that may be closed by this pull request

Create a RIT ADD WORKSPACE command #802

Closed

1 task

henriquemoraeszup reviewed Dec 21, 2020

View reviewed changes

aronrichter requested a review from henriquemoraeszup December 21, 2020 13:14

henriquemoraeszup reviewed Dec 21, 2020

View reviewed changes

henriquemoraeszup mentioned this pull request Dec 21, 2020

Tests with Testify in Pkg/Cmd #776

Closed

34 tasks

aronrichter requested a review from henriquemoraeszup December 21, 2020 21:14

henriquemoraeszup reviewed Dec 21, 2020

View reviewed changes

henriquemoraeszup previously approved these changes Dec 21, 2020

View reviewed changes

kaduartur suggested changes Dec 22, 2020

View reviewed changes

created rit add workspace command

b6705fd

Signed-off-by: Aron Richter <aronrichter@gmail.com>

aronrichter dismissed henriquemoraeszup’s stale review via b6705fd December 22, 2020 21:51

aronrichter requested a review from kaduartur December 22, 2020 21:51

brunasilvazup added the ✔️ ready-for-review ready for review label Dec 23, 2020

kaduartur approved these changes Dec 23, 2020

View reviewed changes

kaduartur added the 🚀 QA label Dec 23, 2020

kaduartur merged commit 38d31e7 into ZupIT:master Dec 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

created rit add workspace command #809

created rit add workspace command #809

aronrichter commented Dec 19, 2020

henriquemoraeszup left a comment

codecov-io commented Dec 19, 2020 •

edited

Loading

henriquemoraeszup Dec 21, 2020

aronrichter Dec 21, 2020

henriquemoraeszup Dec 21, 2020

aronrichter Dec 21, 2020

henriquemoraeszup Dec 21, 2020

aronrichter Dec 21, 2020

henriquemoraeszup left a comment

henriquemoraeszup Dec 21, 2020

henriquemoraeszup left a comment •

edited

Loading

kaduartur left a comment

kaduartur Dec 22, 2020

kaduartur Dec 22, 2020

kaduartur left a comment

kaduartur commented Dec 23, 2020

ritchie-bot bot commented Dec 23, 2020

kaduartur commented Dec 23, 2020

ritchie-bot bot commented Dec 23, 2020

created rit add workspace command #809

created rit add workspace command #809

Conversation

aronrichter commented Dec 19, 2020

Description

How to verify it

Changelog

henriquemoraeszup left a comment

Choose a reason for hiding this comment

codecov-io commented Dec 19, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henriquemoraeszup left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henriquemoraeszup left a comment • edited Loading

Choose a reason for hiding this comment

kaduartur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaduartur left a comment

Choose a reason for hiding this comment

kaduartur commented Dec 23, 2020

ritchie-bot bot commented Dec 23, 2020

kaduartur commented Dec 23, 2020

ritchie-bot bot commented Dec 23, 2020

codecov-io commented Dec 19, 2020 •

edited

Loading

henriquemoraeszup left a comment •

edited

Loading