-
Notifications
You must be signed in to change notification settings - Fork 102
Feature - input autocomplete #821
Feature - input autocomplete #821
Conversation
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 84.34% 84.33% -0.01%
==========================================
Files 111 111
Lines 3857 3868 +11
==========================================
+ Hits 3253 3262 +9
- Misses 432 433 +1
- Partials 172 173 +1
Continue to review full report at Codecov.
|
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! just a couple of comments
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
/merge qa |
👌 Merged branch feature/input-autocomplete into qa |
/merge qa |
🔥 Merge Conflict |
/merge qa |
👌 Merged branch feature/input-autocomplete into qa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you run --help
the flag of a path input is not mapping. It is also recommended to autofill just enough for the common option, not just pick the first one. Example
ls
ritchie-cli ritchie-henrique
if I type r
then tab
it should fill up to ritchie-
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
The |
/merge qa |
🔥 Merge Conflict |
/merge qa |
👌 Merged branch feature/input-autocomplete into qa |
Description
Added input autocomplete(https://github.com/JoaoDanielRufino/go-input-autocomplete) to all workspaces input. Also, I added the option type path on config.json to include this input
How to verify it
Run any formula with type path on config.json or any command that requires the user to enter the path to their workspaces. Hit tab key to autocomplete the path.
Example of config.json:
Changelog
Input Autocomplete