Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Feature - input autocomplete #821

Merged
merged 27 commits into from
Mar 9, 2021
Merged

Feature - input autocomplete #821

merged 27 commits into from
Mar 9, 2021

Conversation

JoaoDanielRufino
Copy link
Contributor

@JoaoDanielRufino JoaoDanielRufino commented Jan 7, 2021

Description

Added input autocomplete(https://github.com/JoaoDanielRufino/go-input-autocomplete) to all workspaces input. Also, I added the option type path on config.json to include this input

How to verify it

Run any formula with type path on config.json or any command that requires the user to enter the path to their workspaces. Hit tab key to autocomplete the path.
Example of config.json:

"inputs": [
    {
      "label": "Type your path: ",
      "name": "rit_path",
      "type": "path",
      "required": true
    }
  ]

Changelog

Input Autocomplete

Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
@joaorufinozup joaorufinozup added ✨ feature Suggest a new feature or enhancement to the Ritchie project 🚧 WIP Work in Progress labels Jan 7, 2021
@JoaoDanielRufino JoaoDanielRufino marked this pull request as draft January 7, 2021 18:29
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #821 (c6a70ad) into master (37ab4d1) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
- Coverage   84.34%   84.33%   -0.01%     
==========================================
  Files         111      111              
  Lines        3857     3868      +11     
==========================================
+ Hits         3253     3262       +9     
- Misses        432      433       +1     
- Partials      172      173       +1     
Impacted Files Coverage Δ
pkg/cmd/create_formula.go 86.11% <66.66%> (+0.09%) ⬆️
pkg/formula/input/prompt/prompt.go 92.63% <83.33%> (-0.96%) ⬇️
pkg/cmd/add_workspace.go 86.04% <100.00%> (+0.33%) ⬆️
pkg/cmd/delete_formula.go 74.84% <100.00%> (+0.15%) ⬆️
pkg/commands/builder.go 90.35% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ab4d1...c6a70ad. Read the comment docs.

Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
@joaorufinozup joaorufinozup marked this pull request as ready for review January 13, 2021 13:59
@joaorufinozup joaorufinozup removed the 🚧 WIP Work in Progress label Jan 13, 2021
kaduartur
kaduartur previously approved these changes Jan 13, 2021
Copy link
Contributor

@kaduartur kaduartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@brunasilvazup brunasilvazup added 📚 documentation Improvements or additions to documentation ✔️ ready-for-review ready for review labels Jan 14, 2021
Copy link
Contributor

@henriquemoraeszup henriquemoraeszup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! just a couple of comments

pkg/cmd/add_workspace_test.go Outdated Show resolved Hide resolved
pkg/formula/input/prompt/prompt_test.go Outdated Show resolved Hide resolved
pkg/formula/runner/docker/runner_test.go Outdated Show resolved Hide resolved
pkg/formula/runner/local/runner_test.go Outdated Show resolved Hide resolved
@brunasilvazup brunasilvazup added 🕒 Wait waiting reply Waiting for an answer to a comment and removed 🚀 QA labels Jan 29, 2021
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
@henriquemoraeszup henriquemoraeszup removed 🕒 Wait waiting reply Waiting for an answer to a comment labels Feb 26, 2021
@henriquemoraeszup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Feb 26, 2021

👌 Merged branch feature/input-autocomplete into qa

@henriquemoraeszup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Mar 4, 2021

🔥 Merge Conflict

@henriquemoraeszup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Mar 4, 2021

👌 Merged branch feature/input-autocomplete into qa

Copy link
Contributor

@henriquemoraeszup henriquemoraeszup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you run --help the flag of a path input is not mapping. It is also recommended to autofill just enough for the common option, not just pick the first one. Example

ls
ritchie-cli    ritchie-henrique

if I type r then tab it should fill up to ritchie-

@henriquemoraeszup henriquemoraeszup added waiting reply Waiting for an answer to a comment and removed 🚀 QA labels Mar 4, 2021
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
@joaorufinozup
Copy link

joaorufinozup commented Mar 5, 2021

When you run --help the flag of a path input is not mapping. It is also recommended to autofill just enough for the common option, not just pick the first one. Example

ls
ritchie-cli    ritchie-henrique

if I type r then tab it should fill up to ritchie-

The --help flag is working now

@henriquemoraeszup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Mar 5, 2021

🔥 Merge Conflict

@henriquemoraeszup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Mar 8, 2021

👌 Merged branch feature/input-autocomplete into qa

@henriquemoraeszup henriquemoraeszup added ✔️ ready-for-review ready for review 🚀 QA and removed waiting reply Waiting for an answer to a comment labels Mar 9, 2021
@henriquemoraeszup henriquemoraeszup merged commit dd9f47e into ZupIT:master Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 documentation Improvements or additions to documentation ✔️ ready-for-review ready for review ✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants