This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
Set credential flags #824
Merged
lucasdittrichzup
merged 24 commits into
ZupIT:master
from
henriquemoraeszup:hm/set-credential-flags
Jan 22, 2021
Merged
Set credential flags #824
lucasdittrichzup
merged 24 commits into
ZupIT:master
from
henriquemoraeszup:hm/set-credential-flags
Jan 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> merge
…credential-flags Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # pkg/cmd/cmd.go # pkg/cmd/delete_credential.go # pkg/cmd/delete_credential_test.go
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Fixing tests and mocks
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
…credential-flags Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # internal/mocks/mocks.go
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
…dential-flags merge.
henriquemoraeszup
requested review from
brunasilvazup,
kaduartur,
lucasdittrichzup and
rodrigomedeirosf
as code owners
January 10, 2021 13:54
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Implementing tests
henriquemoraeszup
force-pushed
the
hm/set-credential-flags
branch
from
January 10, 2021 13:55
079e381
to
55efc23
Compare
…dential-flags Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> # Conflicts: # pkg/cmd/cmd.go # pkg/cmd/delete_credential.go # pkg/cmd/formula.go
henriquemoraeszup
added
📚 documentation
Improvements or additions to documentation
🔨 improvement
Improvement in features
labels
Jan 11, 2021
34 tasks
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
==========================================
- Coverage 84.34% 84.01% -0.33%
==========================================
Files 111 111
Lines 3857 3873 +16
==========================================
+ Hits 3253 3254 +1
- Misses 432 438 +6
- Partials 172 181 +9
Continue to review full report at Codecov.
|
…dential-flags upstream update.
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
brunasilvazup
approved these changes
Jan 15, 2021
lucasdittrichzup
approved these changes
Jan 20, 2021
/merge qa |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
📚 documentation
Improvements or additions to documentation
🔨 improvement
Improvement in features
✔️ ready-for-review
ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rit set credential
with provider, fields, and values. Fields and values are a comma separated list of strings.How to verify it
Run
rit set credential --provider=github fields=username,token values=user1,token1
Changelog
Added flag capacity to
rit set credential
Removed add new credential from filepath capacity