This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Removing file util package with test refactor #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
henriquemoraeszup
requested review from
brunasilvazup,
kaduartur,
lucasdittrichzup and
rodrigomedeirosf
as code owners
This was
linked to
issues
Jan 18, 2021
Closed
brunasilvazup
added
waiting reply
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
==========================================
- Coverage 84.34% 84.31% -0.03%
==========================================
Files 111 111
Lines 3857 3852 -5
==========================================
- Hits 3253 3248 -5
Misses 432 432
Partials 172 172
Continue to review full report at Codecov.
|
henriquemoraeszup
added
✔️ ready-for-review
lucasdittrichzup
previously approved these changes
Jan 22, 2021
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
brunasilvazup
approved these changes
Jan 22, 2021
lucasdittrichzup
approved these changes
Jan 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henrique Moraes henrique.moraes@zup.com.br
Description
Removing the file util package. Since it was used on the
workspacepackage, I took the liberty of also refactoring workspace tests.How to verify it
The project should pass on the ci pipeline and not break on your machine
Changelog
Removed deprecated package fileutil