Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

Support for list input type #843

Merged
merged 8 commits into from
Feb 8, 2021
Merged

Support for list input type #843

merged 8 commits into from
Feb 8, 2021

Conversation

henriquemoraeszup
Copy link
Contributor

@henriquemoraeszup henriquemoraeszup commented Jan 28, 2021 •
edited
Loading

Description

An excuse to refactor package prompt tests. Some of the implementations in this PR

  • Support for list type in the config.json file
  • Removed mocks from the test file
  • Test refactor of the 900+ lines of code to comply with the new implementation method (closes Tests with Testify in Pkg/Formula/Input/Prompt #783 )
  • Removed fileManager dependency from prompt
  • Tests actually check if envs were created
  • Removed non dynamic entries from table tests
  • Removed table test from Default test, since it only had a single test

How to verify it

Run a formula with the config "type": "list", it should work normally

Changelog

Support for list input type

@henriquemoraeszup
List implementation
9104a2a 
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup
Finished prompt tests
cef2b9f 
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup henriquemoraeszup added 📚 documentation Improvements or additions to documentation 🔨 improvement Improvement in features labels Jan 28, 2021
@henriquemoraeszup henriquemoraeszup self-assigned this Jan 28, 2021
@henriquemoraeszup
Linter
08b7ff5 
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup henriquemoraeszup linked an issue Jan 28, 2021 that may be closed by this pull request
Support for list input type #812
Closed
@henriquemoraeszup
Coverage and some tests fix
8877ba3 
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup
Linter
ec54bbb 
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup
unnecessary test
73e2a10 
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup
Fixing tests
26eb7e7 
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@brunasilvazup brunasilvazup added the ✔️ ready-for-review ready for review label Feb 3, 2021
brunasilvazup
brunasilvazup previously approved these changes Feb 4, 2021
View reviewed changes
kaduartur
kaduartur suggested changes Feb 5, 2021
View reviewed changes
@brunasilvazup brunasilvazup added waiting reply Waiting for an answer to a comment and removed ✔️ ready-for-review ready for review labels Feb 5, 2021
@henriquemoraeszup
Code review
c305e23 
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup henriquemoraeszup added ✔️ ready-for-review ready for review and removed waiting reply Waiting for an answer to a comment labels Feb 5, 2021
@brunasilvazup brunasilvazup merged commit b58b1a6 into ZupIT:master Feb 8, 2021
@brunasilvazup brunasilvazup mentioned this pull request Feb 8, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaduartur kaduartur kaduartur approved these changes

@brunasilvazup brunasilvazup brunasilvazup approved these changes

@lucasdittrichzup lucasdittrichzup Awaiting requested review from lucasdittrichzup

@rodrigomedeirosf rodrigomedeirosf Awaiting requested review from rodrigomedeirosf

Assignees

@henriquemoraeszup henriquemoraeszup

Labels
📚 documentation Improvements or additions to documentation 🔨 improvement Improvement in features ✔️ ready-for-review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for list input type Tests with Testify in Pkg/Formula/Input/Prompt
3 participants
@henriquemoraeszup @kaduartur @brunasilvazup