Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Tutorial flags #846

Merged
merged 4 commits into from
Feb 9, 2021
Merged

Conversation

henriquemoraeszup
Copy link
Contributor

Description

How to verify it

You can run rit tutorial --enabled=false and check that the tutorial has been disabled

Changelog

Added flag support for rit tutorial command

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup henriquemoraeszup added 📚 documentation Improvements or additions to documentation 🔨 improvement Improvement in features labels Feb 2, 2021
@henriquemoraeszup henriquemoraeszup self-assigned this Feb 2, 2021
@henriquemoraeszup henriquemoraeszup mentioned this pull request Feb 2, 2021
34 tasks
brunasilvazup
brunasilvazup previously approved these changes Feb 2, 2021
Copy link
Contributor

@brunasilvazup brunasilvazup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

pkg/cmd/tutorial.go Outdated Show resolved Hide resolved
pkg/rtutorial/finder.go Outdated Show resolved Hide resolved
pkg/rtutorial/setter.go Outdated Show resolved Hide resolved
@brunasilvazup brunasilvazup added waiting reply Waiting for an answer to a comment and removed ✔️ ready-for-review ready for review labels Feb 9, 2021
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Copy link
Contributor

@kaduartur kaduartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@henriquemoraeszup henriquemoraeszup added ✔️ ready-for-review ready for review and removed waiting reply Waiting for an answer to a comment labels Feb 9, 2021
@brunasilvazup brunasilvazup merged commit aafbea6 into ZupIT:master Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 documentation Improvements or additions to documentation 🔨 improvement Improvement in features ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests with Testify in Pkg/RTutorial Support flags for rit tutorial
4 participants