This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
Tutorial flags #846
Merged
brunasilvazup
merged 4 commits into
ZupIT:master
from
henriquemoraeszup:hm/tutorial-flags
Feb 9, 2021
Merged
Tutorial flags #846
brunasilvazup
merged 4 commits into
ZupIT:master
from
henriquemoraeszup:hm/tutorial-flags
Feb 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
henriquemoraeszup
added
📚 documentation
Improvements or additions to documentation
🔨 improvement
Improvement in features
labels
Feb 2, 2021
henriquemoraeszup
requested review from
brunasilvazup,
kaduartur,
lucasdittrichzup and
rodrigomedeirosf
as code owners
February 2, 2021 18:20
34 tasks
brunasilvazup
previously approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
lucasdittrichzup
previously approved these changes
Feb 9, 2021
kaduartur
suggested changes
Feb 9, 2021
brunasilvazup
added
waiting reply
Waiting for an answer to a comment
and removed
✔️ ready-for-review
ready for review
labels
Feb 9, 2021
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
henriquemoraeszup
dismissed stale reviews from lucasdittrichzup and brunasilvazup
via
February 9, 2021 16:29
42acda4
brunasilvazup
requested review from
kaduartur,
lucasdittrichzup and
brunasilvazup
February 9, 2021 16:47
kaduartur
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
henriquemoraeszup
added
✔️ ready-for-review
ready for review
and removed
waiting reply
Waiting for an answer to a comment
labels
Feb 9, 2021
brunasilvazup
approved these changes
Feb 9, 2021
lucasdittrichzup
approved these changes
Feb 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
📚 documentation
Improvements or additions to documentation
🔨 improvement
Improvement in features
✔️ ready-for-review
ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rit tutorial
command (closes Support flags for rit tutorial #715 )rtutorial
tests (closes Tests with Testify in Pkg/RTutorial #795 )How to verify it
You can run
rit tutorial --enabled=false
and check that the tutorial has been disabledChangelog
Added flag support for rit tutorial command