This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
[BUGFIX] - Fix build with build.sh #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabiano Chiareto Fernandes <fabiano.fernandes@zup.com.br>
fabianofernandeszup
added
the
🪲 bug
fabianofernandeszup
requested review from
brunasilvazup,
henriquemoraeszup,
kaduartur,
lucasdittrichzup and
rodrigomedeirosf
as code owners
henriquemoraeszup
approved these changes
Feb 18, 2021
Closed
|
/merge qa |
|
🔥 Merge Conflict |
|
/merge qa |
|
🔥 Merge Conflict |
GuillaumeFalourd
approved these changes
Feb 18, 2021
lucasdittrichzup
approved these changes
Feb 18, 2021
|
/merge qa |
|
👌 Merged branch fix-build-with-shell-script into qa |
henriquemoraeszup
pushed a commit
that referenced
this pull request
Feb 22, 2021
Signed-off-by: Fabiano Chiareto Fernandes <fabiano.fernandes@zup.com.br>
henriquemoraeszup
added a commit
that referenced
this pull request
Feb 22, 2021
* Fixing delete credential empty fields bug (#864) * Fix build with build.sh (#862) Signed-off-by: Fabiano Chiareto Fernandes <fabiano.fernandes@zup.com.br> * Update repo fix (#866) * [ci skip] release Co-authored-by: henriquemoraeszup <68074718+henriquemoraeszup@users.noreply.github.com> Co-authored-by: Fabiano Chiaretto Fernandes <58859234+fabianofernandeszup@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabiano Chiareto Fernandes fabiano.fernandes@zup.com.br
Description
The build process checks for the existence of the build.sh file in the formula and, if not found, proceed to the build through the makefile.
But when the formula has both files, it generates an error, because first the build.sh is executed and then the makefile, and this error is captured by the cli as a build execution error.
The formula template is using both files to maintain compatibility with previous versions of the cli.
How to verify it
Create a new formula such as shell-bat. (Commons release 2.15.1)
When executing the first time, there will be a build error message with makefile, as in the image below.
Changelog