This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Adding safety check to workspace add #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
henriquemoraeszup
added
the
🪲 bug
henriquemoraeszup
requested review from
brunasilvazup,
kaduartur,
lucasdittrichzup and
rodrigomedeirosf
as code owners
|
/merge qa |
|
👌 Merged branch hm/workspace-add-safety into qa |
|
/merge qa |
|
👌 Merged branch hm/workspace-add-safety into qa |
|
/merge qa |
|
👌 Merged branch hm/workspace-add-safety into qa |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henrique Moraes henrique.moraes@zup.com.br
Description
If a user tries to add a workspace with a trailing separator, it breaks the autobuild feature when mapping the workspace to the
.ritdirectoryHow to verify it
Run
rit add workspace, add a trailing separator on the path (i.e:/my/repo/), run a formula, edit, and run again. Autobuild should work normallyChangelog
Fixing bug when adding trailing separator to workspace