This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Multiselect flag support #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
…lect-flag-support merge
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
henriquemoraeszup
added
the
🪲 bug
henriquemoraeszup
requested review from
brunasilvazup,
kaduartur,
lucasdittrichzup and
rodrigomedeirosf
as code owners
lucasdittrichzup
previously approved these changes
Mar 4, 2021
|
/merge qa |
|
🔥 Merge Conflict |
|
/merge qa |
|
👌 Merged branch hm/multiselect-flag-support into qa |
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
henriquemoraeszup
dismissed stale reviews from lucasdittrichzup, brunasilvazup, and GuillaumeFalourd
via
3973346
|
/merge qa |
|
👌 Merged branch hm/multiselect-flag-support into qa |
lucasdittrichzup
approved these changes
Mar 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding a
multiselectinput, Ritchie could not translate it into flags. We need to take this case into accountlistinput type commandlistinput type inputmultiselectinput type commandmultiselectinput type inputformulapackageCloses #881
Closes #791
How to verify it
Add a
multiselectinput and run--help, the input should be listedChangelog
Supporting flags for multiselect input