This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Changing conditional to only return an error when the conditional input variable does not exist in the config.json variable list #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al input variable does not exist in the config.json variable list Signed-off-by: Finzi <andressa.abreu@zup.com.br>
Signed-off-by: Finzi <andressa.abreu@zup.com.br>
andressaabreuzup
requested review from
brunasilvazup,
henriquemoraeszup,
kaduartur,
lucasdittrichzup and
rodrigomedeirosf
as code owners
andressaabreuzup
added
🔨 improvement
henriquemoraeszup
previously approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Hey @andressaabreuzup ! Nice description, thank you. Really helped understand the problem. I am good to go but it seems there is a lint problem 😄
Signed-off-by: Finzi <andressa.abreu@zup.com.br>
Signed-off-by: Finzi <andressa.abreu@zup.com.br>
andressaabreuzup
force-pushed
the
fix/nested-conditional-error
branch
from
e7957d1 to
e2e78f8
Compare
It was a spacing problem, I fixed it, now it's 100% :) |
|
/merge qa |
|
👌 Merged branch fix/nested-conditional-error into qa |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Finzi andressa.abreu@zup.com.br
Description
Formulas with nested conditional inputs were returning an unnecessary error.
When there were two flows of nested conditionals, for example, consequently one of them was not satisfied. But an error was returned when the variables of the alternative flow conditionals were tested. The error said that such variables did not exist, however, they existed. They just weren't being filled by belonging to that other flow that didn't happen.
How to verify it
Test nested conditional inputs with a alternative flow. (Not a error)
Test conditional inputs that not exists. (A error)
Changelog
Changing conditional to only return an error when the conditional input variable does not exist in the config.json variable list