This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Feature/functional tests #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix space on config for circleCI 2
Fix golint issues 2
Change the path for workspace Change the path for workspace 2 Change the path for workspace 3
Change unit test job to run based on circleCi config 2 Change unit test job to run based on circleCi config 3 Change unit test job to run based on circleCi config 4
dmbarra
requested review from
sandokandias,
kaduartur,
marcosgmgm,
viniciusramosdefaria,
GuillaumeFalourd,
ernelio and
victorschumacherzup
victor-schumacher
approved these changes
May 15, 2020
viniciusramosdefaria
approved these changes
May 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Created a suite of functional tests to validate core functionalities for SINGLE mode.
Changed pipeline workflow to run tests after build.
Added test commands at CONTRIBUTING.md
I renamed the old test job and runner to unit_test and add the functional_test job and runner.
- How I did it
For the functional_test I created the base commands inside the file: runner.go. I created the test runner runner_integration_test.go and two files to contain the test entries. Also, add JSON with scenarios, following a model I designed to facilitate the specification
To add the functional tests at pipeline I created a new task at makefile and I created a new job and add that after the build. I DIDN'T created dependencies to deploy or delivery for this new job.
- How to verify it
Make functional-test
Make unit-test
Follow the pipeline build