Fix --fonts CLI option #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option was introduced many years ago and has since bit-rotted.
I don't have fonts installed globally on my system, so I need to use the `--fonts` option.
But without this commit, I get the following error when trying to use the `--fonts` option:
```
Traceback (most recent call last):
File "/path/to/nik4.py", line 677, in <module>
run(options)
File "/path/to/nik4.py", line 422, in run
mapnik.load_map_from_string(m, style_xml.encode("utf-8"), False, style_path)
RuntimeError: no valid fonts could be loaded in FontSet 'fontset-0' in FontSet at line 15
```
To fix this, load the fonts earlier. The exact place where we load them is not important, as long as it is above all calls to mapnik functions, which require fonts to be loaded (`mapnik.load_map_from_string()` currently). To be on the safe side regarding future modifications, I moved the code snippet pretty much to the top of the function, which results in this option working again.
|
Thank you! I've published it in 1.8. |
|
Awesome, thanks! |
|
Could you please also create a Git tag and GitHub release? |
|
Yup, done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was introduced many years ago and has since bit-rotted.
I don't have fonts installed globally on my system, so I need to use the
--fontsoption.But without this commit, I get the following error when trying to use the
--fontsoption:To fix this, load the fonts earlier. The exact place where we load them is not important, as long as it is above all calls to mapnik functions, which require fonts to be loaded (
mapnik.load_map_from_string()currently). To be on the safe side regarding future modifications, I moved the code snippet pretty much to the top of the function, which results in this option working again.