-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(git): 🧑💻 vs code git commit signing #488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable commit signing in VS Code by default
VermiumSifell
requested review from
a team,
Axelen123 and
Pajsen9263
and removed request for
a team
November 3, 2022 17:24
Axelen123
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
VermiumSifell
added a commit
that referenced
this pull request
Nov 4, 2022
…491) * Added missing package and improve user/dev experience (#486) * fix: 📦 add date-fns Added missing date-fns to dependency list * style(git): 🧑💻 start using Conventional Commits Started using a commit convention called Conventional Commits (conventionalcommits.org) * chore(github): 🚸 Remove issue templates Removed issue templates since they confuses people and makes less people go through and make an issue * feat(git): 🧑💻 vs code git commit signing (#488) Enable commit signing in VS Code by default
Merged
VermiumSifell
added a commit
that referenced
this pull request
Nov 4, 2022
…491) (#493) * Added missing package and improve user/dev experience (#486) * fix: 📦 add date-fns Added missing date-fns to dependency list * style(git): 🧑💻 start using Conventional Commits Started using a commit convention called Conventional Commits (conventionalcommits.org) * chore(github): 🚸 Remove issue templates Removed issue templates since they confuses people and makes less people go through and make an issue * feat(git): 🧑💻 vs code git commit signing (#488) Enable commit signing in VS Code by default
VermiumSifell
added a commit
that referenced
this pull request
Nov 4, 2022
Enable commit signing in VS Code by default
VermiumSifell
added a commit
that referenced
this pull request
Nov 4, 2022
…491) (#493) * Added missing package and improve user/dev experience (#486) * fix: 📦 add date-fns Added missing date-fns to dependency list * style(git): 🧑💻 start using Conventional Commits Started using a commit convention called Conventional Commits (conventionalcommits.org) * chore(github): 🚸 Remove issue templates Removed issue templates since they confuses people and makes less people go through and make an issue * feat(git): 🧑💻 vs code git commit signing (#488) Enable commit signing in VS Code by default
VermiumSifell
added a commit
that referenced
this pull request
Nov 4, 2022
* Fix missing packages and make signing commits as default in VS Code (#491) * Added missing package and improve user/dev experience (#486) * fix: 📦 add date-fns Added missing date-fns to dependency list * style(git): 🧑💻 start using Conventional Commits Started using a commit convention called Conventional Commits (conventionalcommits.org) * chore(github): 🚸 Remove issue templates Removed issue templates since they confuses people and makes less people go through and make an issue * feat(git): 🧑💻 vs code git commit signing (#488) Enable commit signing in VS Code by default * 🚸 improve dev experience in vs code * 📦 Removed unused and updated packages * Added missing package and improve user/dev experience (#486) * fix: 📦 add date-fns Added missing date-fns to dependency list * style(git): 🧑💻 start using Conventional Commits Started using a commit convention called Conventional Commits (conventionalcommits.org) * chore(github): 🚸 Remove issue templates Removed issue templates since they confuses people and makes less people go through and make an issue * feat(git): 🧑💻 vs code git commit signing (#488) Enable commit signing in VS Code by default * chore: ⚰️ remove config for unused github apps (#492) Removed configuration files for licrc and renovate since they are not used anymore * Updated CI workflows (#494) * ci(github): 👷 add arm64 support and run workflow with cron and on push and pull request Added support for linux/arm64 platform, I also added a cronjob and added pull_request as triggers to run the workflow * ci: 🚸 add ghcr.io as registry too Added ghcr.io as a registry aswell as keeping docker hub too * ci: 👷 add release workflow (semantic release) Added a new workflow for semantic releases * ci: 💚 remove strategy Removed strategy's since they were not used * ci: 💚 change frmo master to main Change from wrong branch (master) to main in workflow * chore: ✏️ master should be main Changed from master to main in releaserc * Update .deepsource.toml (#487) Co-authored-by: DeepSource Bot <bot@deepsource.io> * Format code with prettier (#489) This commit fixes the style issues introduced in 502f8b1 according to the output from prettier. Details: https://deepsource.io/gh/ZynerOrg/xyter/transform/2d6f5e66-ae8b-4261-92a6-688077649213/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * Fix missing packages and make signing commits as default in VS Code (#491) (#493) * Added missing package and improve user/dev experience (#486) * fix: 📦 add date-fns Added missing date-fns to dependency list * style(git): 🧑💻 start using Conventional Commits Started using a commit convention called Conventional Commits (conventionalcommits.org) * chore(github): 🚸 Remove issue templates Removed issue templates since they confuses people and makes less people go through and make an issue * feat(git): 🧑💻 vs code git commit signing (#488) Enable commit signing in VS Code by default Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: DeepSource Bot <bot@deepsource.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable commit signing in VS Code by default
Also includes fix of duplicated configurations in VS Code settings