Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing packages and make signing commits as default in VS Code #491

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

VermiumSifell
Copy link
Member

@VermiumSifell VermiumSifell commented Nov 4, 2022

Well I think the title says everything on this one.

* fix: 📦 add date-fns

Added missing date-fns to dependency list

* style(git): 🧑‍💻 start using Conventional Commits

Started using a commit convention called Conventional Commits (conventionalcommits.org)

* chore(github): 🚸 Remove issue templates

Removed issue templates since they confuses people and makes less people go through and make an issue
Enable commit signing in VS Code by default
@VermiumSifell VermiumSifell requested review from a team, Axelen123 and Pajsen9263 and removed request for a team November 4, 2022 00:07
Copy link

@Axelen123 Axelen123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the issue template here?

@VermiumSifell
Copy link
Member Author

Why are you removing the issue template here?

Because I think it didn't make any sense to users, it just confuses people since it's kinda outdated and there are not templates for the most commons stuff like Ideas and so on.

@VermiumSifell VermiumSifell requested a review from a team November 4, 2022 12:49
Copy link

@axel-06 axel-06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VermiumSifell VermiumSifell removed the request for review from Pajsen9263 November 4, 2022 12:55
@VermiumSifell VermiumSifell merged commit 5e1e1d4 into next Nov 4, 2022
@VermiumSifell VermiumSifell mentioned this pull request Nov 4, 2022
VermiumSifell added a commit that referenced this pull request Nov 4, 2022
…491) (#493)

* Added missing package and improve user/dev experience (#486)

* fix: 📦 add date-fns

Added missing date-fns to dependency list

* style(git): 🧑‍💻 start using Conventional Commits

Started using a commit convention called Conventional Commits (conventionalcommits.org)

* chore(github): 🚸 Remove issue templates

Removed issue templates since they confuses people and makes less people go through and make an issue

* feat(git): 🧑‍💻 vs code git commit signing (#488)

Enable commit signing in VS Code by default
@Axelen123
Copy link

Why are you removing the issue template here?

Because I think it didn't make any sense to users, it just confuses people since it's kinda outdated and there are not templates for the most commons stuff like Ideas and so on.

Ah I see

VermiumSifell added a commit that referenced this pull request Nov 4, 2022
…491) (#493)

* Added missing package and improve user/dev experience (#486)

* fix: 📦 add date-fns

Added missing date-fns to dependency list

* style(git): 🧑‍💻 start using Conventional Commits

Started using a commit convention called Conventional Commits (conventionalcommits.org)

* chore(github): 🚸 Remove issue templates

Removed issue templates since they confuses people and makes less people go through and make an issue

* feat(git): 🧑‍💻 vs code git commit signing (#488)

Enable commit signing in VS Code by default
VermiumSifell added a commit that referenced this pull request Nov 4, 2022
* Fix missing packages and make signing commits as default in VS Code (#491)

* Added missing package and improve user/dev experience (#486)

* fix: 📦 add date-fns

Added missing date-fns to dependency list

* style(git): 🧑‍💻 start using Conventional Commits

Started using a commit convention called Conventional Commits (conventionalcommits.org)

* chore(github): 🚸 Remove issue templates

Removed issue templates since they confuses people and makes less people go through and make an issue

* feat(git): 🧑‍💻 vs code git commit signing (#488)

Enable commit signing in VS Code by default

* 🚸 improve dev experience in vs code

* 📦 Removed unused and updated packages

* Added missing package and improve user/dev experience (#486)

* fix: 📦 add date-fns

Added missing date-fns to dependency list

* style(git): 🧑‍💻 start using Conventional Commits

Started using a commit convention called Conventional Commits (conventionalcommits.org)

* chore(github): 🚸 Remove issue templates

Removed issue templates since they confuses people and makes less people go through and make an issue

* feat(git): 🧑‍💻 vs code git commit signing (#488)

Enable commit signing in VS Code by default

* chore: ⚰️ remove config for unused github apps (#492)

Removed configuration files for licrc and renovate since they are not used anymore

* Updated CI workflows (#494)

* ci(github): 👷 add arm64 support and run workflow with cron and on push and pull request

Added support for linux/arm64 platform, I also added a cronjob and added pull_request as triggers to run the workflow

* ci: 🚸 add ghcr.io as registry too

Added ghcr.io as a registry aswell as keeping docker hub too

* ci: 👷 add release workflow (semantic release)

Added a new workflow for semantic releases

* ci: 💚 remove strategy

Removed strategy's since they were not used

* ci: 💚 change frmo master to main

Change from wrong branch (master) to main in workflow

* chore: ✏️ master should be main

Changed from master to main in releaserc

* Update .deepsource.toml (#487)

Co-authored-by: DeepSource Bot <bot@deepsource.io>

* Format code with prettier (#489)

This commit fixes the style issues introduced in 502f8b1 according to the output
from prettier.

Details: https://deepsource.io/gh/ZynerOrg/xyter/transform/2d6f5e66-ae8b-4261-92a6-688077649213/

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Fix missing packages and make signing commits as default in VS Code (#491) (#493)

* Added missing package and improve user/dev experience (#486)

* fix: 📦 add date-fns

Added missing date-fns to dependency list

* style(git): 🧑‍💻 start using Conventional Commits

Started using a commit convention called Conventional Commits (conventionalcommits.org)

* chore(github): 🚸 Remove issue templates

Removed issue templates since they confuses people and makes less people go through and make an issue

* feat(git): 🧑‍💻 vs code git commit signing (#488)

Enable commit signing in VS Code by default

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: DeepSource Bot <bot@deepsource.io>
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

🎉 This PR is included in version 1.0.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants