Add 4kb paging #84
Add 4kb paging #84
Conversation
SamTebbs33
force-pushed
the
feature/4kb-paging
branch
from
a65fabb
to
4407e9e
Compare
| @@ -1,83 +1,138 @@ | |||
| const std = @import("std"); | |||
| const builtin = @import("builtin"); | |||
| const panic = @import("../../kmain.zig").panic; | |||
| const arch = @import("../../arch.zig").internals; | |||
| const isr = @import("isr.zig"); | |||
| const assert = std.debug.assert; | |||
| const MemProfile = @import("../../mem.zig").MemProfile; | |||
There was a problem hiding this comment.
const mem= @import("../../mem.zig");
const MemProfile = mem.MemProfile;There was a problem hiding this comment.
But mem is only used to get MemProfile so there's no point importing it separately.
There was a problem hiding this comment.
So in that case, surly just const mem = @import("../../mem.zig"); and use `mem.MemProfile. Bc what if you want to use something else from mem?
There was a problem hiding this comment.
If you use const MemProfile = @import("../../mem.zig").MemProfile and later on want to use something else from mem, then you can change it to
const mem = @import("../../mem.zig");
const MemProfile = mem.MemProfile;
and use mem wherever.
SamTebbs33
force-pushed
the
feature/4kb-paging
branch
from
62b4fa7
to
5c15376
Compare
SamTebbs33
force-pushed
the
feature/4kb-paging
branch
from
ac13ed0
to
479bd2b
Compare
src/kernel/arch/x86/paging.zig
Outdated
| @@ -372,7 +372,8 @@ test "virtToPhys" { | |||
| const offset: usize = @ptrToInt(&KERNEL_ADDR_OFFSET); | |||
| expectEqual(virtToPhys(offset + 0), 0); | |||
| expectEqual(virtToPhys(offset + 123), 123); | |||
| expectEqual(@ptrToInt(virtToPhys(@intToPtr(*usize, offset + 123))), 123); | |||
| if (builtin.mode != builtin.Mode.ReleaseSafe) | |||
There was a problem hiding this comment.
XD, This is cheating. I think it is bc ur comparing a pointer to a uint. @ptrToInt() != u32
There was a problem hiding this comment.
:( I hoped you wouldn't notice the sneakyness. How do you think I could fix this?
There was a problem hiding this comment.
I've added a workaround. It's not nice, but is all I can get working at the moment. I'll add an issue to monitor it once this is merged.
SamTebbs33
force-pushed
the
feature/4kb-paging
branch
from
c68fa6a
to
59d78c6
Compare
This PR adds 4KB paging support. Closes #79