Get rid of geom::Polygon union operations. They always produced invalid #981
Conversation
| .zorder(1) | ||
| .draw(main_route.draw) | ||
| .build(ctx); | ||
| if self.waypoints.get_waypoints().len() > 1 { |
There was a problem hiding this comment.
For routes with >= 3 waypoints, there are multiple hitboxes per route object in the World. It was most straightforward to just make World handle multiple hitboxes.
| self.body | ||
| .to_thick_boundary(CAR_WIDTH, OUTLINE_THICKNESS) | ||
| .unwrap_or_else(|| self.body_polygon.clone()) | ||
| fn get_outline(&self, _: &Map) -> Tessellation { |
There was a problem hiding this comment.
Very slight change here.
Most of the time, the body polygon narrows in the front. The outline has always just been the simpler rectanglish shape. Before, the hitbox was based on the more detailed narrowed shape. But now the hitbox is also just the simple rectangle. Barely noticeable.
| fn contains_pt(&self, pt: Pt2D, map: &Map) -> bool { | ||
| self.get_outline(map).contains_pt(pt) | ||
| } | ||
| fn get_outline(&self, map: &Map) -> Tessellation; |
There was a problem hiding this comment.
Necessary because some buildings have holes. Polygon::to_outline returns a Tessellation now to handle that case. Returning a Vec<Polygon> (one for exterior, one for each hole) is another option, but it's a gross API. For the callers that want Polygon outlines for each individual ring, they can still do that themselves
| self | ||
| } | ||
|
|
||
| /// Specifies the geometry of the object as a multipolygon. |
There was a problem hiding this comment.
The change here is to let something in a World have multiple polygons as the hitbox. If more places in the code wind up needing something like this, then a MultiPolygon type becomes useful. :)
| @@ -38,10 +38,13 @@ impl ColorLegend { | |||
| .map(|(idx, color)| ((idx as f64) / ((n - 1) as f64), *color)) | |||
| .collect(), | |||
| }), | |||
| Polygon::union_all( | |||
| Tessellation::union_all( | |||
There was a problem hiding this comment.
This is one of the real reasons why unioning tessellations is actually necessary. This is a bunch of rectangles in a row. Why not just one big rectangle? Because we need the points in the middle in order for the shader logic to actually have a chance to evaluate here
polygons. a-b-street/geom#2
CC @michaelkirk