fix: parser hangs when a bracket isn't closed (#1005) #1029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bracket (curly or parentheses) isn't closed, the parser keeps reading until it is closed.
However, the parser NEVER checks if EOF is reached. So, the parser loops when EOF and there's a missing bracket.
Solution:
Check for EOF before handling anything else (could be elsewhere, but I think this makes the most sense).
If the parser is expecting nested functions, then it should return an error with the unclosed bracket.
Example:
Templ:
Result:
Closes #1005