Feature: default to delete orphaned files, with -keepOrphanedFiles argument flag to disable feature #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-h
requested changes
Dec 15, 2023
cmd/templ/generatecmd/main.go
Outdated
| @@ -125,6 +125,38 @@ func runCmd(ctx context.Context, w io.Writer, args Arguments) (err error) { | |||
| p = proxy.New(args.ProxyPort, target) | |||
| } | |||
|
|
|||
| if !args.KeepOrphanedFiles { | |||
There was a problem hiding this comment.
I don't think this is the right place to do this work, because it means walking through the directory tree twice which is relatively expensive to do.
If we can combine the deletion of orphaned files with the generation, I think that would be better. Also, I'm wondering if the deletion of the orphaned file should be a warning or some other level to make it stand out.
There was a problem hiding this comment.
100% right, I was on something. Passed the argument to the processFile function (would that be the way?), checked it and used logWarning for the message.
|
Fixed with your helpful direction. Lmk if it still needs some work! |
a-h
reviewed
Dec 17, 2023
a-h
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default functionality to delete orphans on
templ generate& with the -keep-orphaned-files arg flag
(base2_templ.go isn't deleted)