Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] - Added Note for PATH variable on Readme #350

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

georgeiliadis91
Copy link
Contributor

No description provided.

@a-h
Copy link
Owner

a-h commented Dec 22, 2023

Thanks for this.

From reading this PR, I realised that the install-snapshot script is putting the file in the wrong place. It works on my system, but not for everyone else.

I thought it would be better to go install the package instead, then the command wouldn't need a note, because it's much more likely that anyone that has Go installed has $GOBIN or $HOME/go/bin already in their path as per this page: https://pkg.go.dev/cmd/go#hdr-Compile_and_install_packages_and_dependencies

Executables are installed in the directory named by the GOBIN environment variable, which defaults to $GOPATH/bin or $HOME/go/bin if the GOPATH environment variable is not set. Executables in $GOROOT are installed in $GOROOT/bin or $GOTOOLDIR instead of $GOBIN.

@a-h a-h merged commit 27b594c into a-h:main Dec 22, 2023
4 checks passed
@georgeiliadis91
Copy link
Contributor Author

cheers, appreciate that you included it in the commit chain.

@a-h
Copy link
Owner

a-h commented Dec 22, 2023

Thanks for the contribution, and for taking the time to say that! I think it's the right thing to do. You put work in, I make sure you get listed as a contributor.

I've been on the other side, where I've put work into something and then a maintainer folds it in without credit, which I think is a very uncool thing to do. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants