-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 #154
Patch 1 #154
Conversation
Thanks @amorehead ! Appreciate the PR :) Commented on a few nits. Would you also mind updating the changelog and add yourself to the contributors if you wish? |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 40.27% 47.90% +7.63%
==========================================
Files 48 58 +10
Lines 2811 3822 +1011
==========================================
+ Hits 1132 1831 +699
- Misses 1679 1991 +312
Continue to review full report at Codecov.
|
Reference Issues/PRs
I noticed a TODO statement that I could readily address.
What does this implement/fix? Explain your changes
I added a way of checking that DSSP is executable before trying to use it.
What testing did you do to verify the changes in this PR?
I made sure the code runs locally.