Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bioservices to account for new UniProt API #187

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Jul 6, 2022

Reference Issues/PRs

New UniProt API (and bioservices update) introduces breaking changes into sequence retrieval.

@codecov-commenter
Copy link

Codecov Report

Merging #187 (bc0a102) into master (8123f42) will increase coverage by 8.06%.
The diff coverage is 52.28%.

❗ Current head bc0a102 differs from pull request most recent head fdc2a2e. Consider uploading reports for the commit fdc2a2e to get more accurate results

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   40.27%   48.33%   +8.06%     
==========================================
  Files          48       92      +44     
  Lines        2811     5313    +2502     
==========================================
+ Hits         1132     2568    +1436     
- Misses       1679     2745    +1066     
Impacted Files Coverage Δ
graphein/grn/parse_trrust.py 37.77% <ø> (ø)
graphein/ml/diffusion.py 0.00% <0.00%> (ø)
graphein/ppi/edges.py 100.00% <ø> (ø)
graphein/ppi/graph_metadata.py 0.00% <ø> (ø)
graphein/ppi/graphs.py 54.34% <ø> (ø)
graphein/ppi/parse_biogrid.py 75.00% <ø> (ø)
graphein/ppi/visualisation.py 0.00% <0.00%> (ø)
graphein/protein/analysis.py 0.00% <0.00%> (ø)
graphein/protein/features/sequence/utils.py 28.00% <0.00%> (+3.00%) ⬆️
graphein/protein/features/utils.py 27.77% <0.00%> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55703ee...fdc2a2e. Read the comment docs.

@a-r-j a-r-j merged commit 011d880 into master Jul 6, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@a-r-j a-r-j deleted the 1.5.0-patch2 branch July 6, 2022 15:52
a-r-j added a commit that referenced this pull request Jul 11, 2022
* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <arjamasb@gmail.com>

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>
a-r-j added a commit that referenced this pull request Jul 11, 2022
* refactor PDB download to support parallelisation

* add tests for PDB download

* refactor PDB download function call in getcontacts

* add salt bridges and vdw interactions

* use multiprocess downloading in torch datasets

* add additional edge funcs

* add residue_id to dfs and additional constants

* update tests to account for residue id column

* update dl func to check for obsolete PDBs

* fix type error on paths

* fix obsolete test

* add bad pdb attr

* add return to PDB download util

* Merge master -> Patch (#190)

* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <arjamasb@gmail.com>

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>

* patch torch geometric dataset and update changelog

* black, isort

* isort

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>
a-r-j added a commit that referenced this pull request Jul 12, 2022
* refactor PDB download to support parallelisation

* add tests for PDB download

* refactor PDB download function call in getcontacts

* add salt bridges and vdw interactions

* use multiprocess downloading in torch datasets

* add additional edge funcs

* add residue_id to dfs and additional constants

* update tests to account for residue id column

* update dl func to check for obsolete PDBs

* fix type error on paths

* fix obsolete test

* add bad pdb attr

* add return to PDB download util

* Merge master -> Patch (#190)

* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <arjamasb@gmail.com>

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>

* patch torch geometric dataset and update changelog

* black, isort

* isort

* add edge tests

* remove unused workflow action

* bump for 1.5.0

* add vdw clashes to constants

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>
a-r-j added a commit that referenced this pull request Jul 14, 2022
* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <arjamasb@gmail.com>

* 1.5.0 patch3 (#189)

* refactor PDB download to support parallelisation

* add tests for PDB download

* refactor PDB download function call in getcontacts

* add salt bridges and vdw interactions

* use multiprocess downloading in torch datasets

* add additional edge funcs

* add residue_id to dfs and additional constants

* update tests to account for residue id column

* update dl func to check for obsolete PDBs

* fix type error on paths

* fix obsolete test

* add bad pdb attr

* add return to PDB download util

* Merge master -> Patch (#190)

* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <arjamasb@gmail.com>

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>

* patch torch geometric dataset and update changelog

* black, isort

* isort

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>

* 1.5.0 patch3 (#191)

* refactor PDB download to support parallelisation

* add tests for PDB download

* refactor PDB download function call in getcontacts

* add salt bridges and vdw interactions

* use multiprocess downloading in torch datasets

* add additional edge funcs

* add residue_id to dfs and additional constants

* update tests to account for residue id column

* update dl func to check for obsolete PDBs

* fix type error on paths

* fix obsolete test

* add bad pdb attr

* add return to PDB download util

* Merge master -> Patch (#190)

* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <arjamasb@gmail.com>

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>

* patch torch geometric dataset and update changelog

* black, isort

* isort

* add edge tests

* remove unused workflow action

* bump for 1.5.0

* add vdw clashes to constants

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>

Co-authored-by: Cam <73625486+cimranm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants