[DO NOT MERGE] prototype to use a rust experiments api and expose it #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladikoff
reviewed
Jul 22, 2020
build.gradle
Outdated
| @@ -51,6 +51,7 @@ buildscript { | |||
| } | |||
| } | |||
| dependencies { | |||
|
|
|||
There was a problem hiding this comment.
let's remove the new line changes , so there's less noise
| @@ -65,6 +66,11 @@ android { | |||
| } | |||
|
|
|||
| sourceSets { | |||
| main { | |||
There was a problem hiding this comment.
We might not have this documented in a-s, but could you leave a note what this does?
tarikeshaq
force-pushed
the
test-experiments-do-not-merge
branch
3 times, most recently
from
c243d5e to
83209fd
Compare
tarikeshaq
force-pushed
the
test-experiments-do-not-merge
branch
from
83209fd to
28bbd0e
Compare
vladikoff
reviewed
Jul 23, 2020
| run `git clone git@github.com:a-s-dev/android-components.git` | ||
|
|
||
| Then `git checkout test-experiments-do-not-merge` | ||
| 4. In the `samples-glean` application in Android Components, open [`GleanApplication.kt`](https://github.com/a-s-dev/android-components/blob/test-experiments-do-not-merge/samples/glean/src/main/java/org/mozilla/samples/glean/GleanApplication.kt) and set a break point [here](https://github.com/a-s-dev/android-components/blob/test-experiments-do-not-merge/samples/glean/src/main/java/org/mozilla/samples/glean/GleanApplication.kt#L49) |
There was a problem hiding this comment.
tiny fenix change to run it, once a-c is published locally is here: vladikoff/fenix@ce8a09f
added 2 commits
July 30, 2020 09:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds what's needed on the glean side for a simple Rust experiments crate that compiles with glean. Instructions on how to run this locally is here.