Add support for --no-use-platform-suffix.
#96
Conversation
| Add support for `--no-use-platform-suffix` as a complement to `--use-platform-suffix`. Without | ||
| specifying either, auto-disambiguation is still used to add a platform suffix whenever the | ||
| set of target platforms is not just the current platform, but you can also now force a platform | ||
| suffix to never be used by specifying `--no-use-platform-suffix`. |
There was a problem hiding this comment.
Pex needs this for the --scie-name-style platform-parent-dir option it added in pex-tool/pex#2523 to work right. In addition to the new test in this change, I used --scie-science-binary ... to double check this worked over there (to solve pex-tool/pex#2516) as well.
| @@ -102,3 +103,10 @@ jobs: | |||
| files: dist/science-* | |||
| fail_on_unmatched_files: true | |||
| discussion_category_name: Announcements | |||
| - name: Add Binaries to ${{ needs.determine-tag.outputs.release-tag }} Release | |||
There was a problem hiding this comment.
The Windows machines were messing up the release notes; so I added this fork. We only need release notes and discussion creation to be triggered once since they are not unique per platform like the binaries are; so this makes sense anyhow.
| @@ -542,14 +542,15 @@ def dest_dir_option(): | |||
|
|
|||
| def use_platform_suffix_option(): | |||
| return click.option( | |||
| "--use-platform-suffix", | |||
| is_flag=True, | |||
| "--use-platform-suffix/--no-use-platform-suffix", | |||
There was a problem hiding this comment.
The docsite / this CLI help rendered here: https://jsirois.github.io/lift/cli.html#science-lift-build
|
I'm going to move this one along since its small and I'd like to both check the release fix and get Pex rolling along with its fix based on this new option. Consider this FYI. |
No description provided.