Make it run again #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the 4 remote rep subsystem effect bonuses to calculate early in the engine. This correctly calculates these bonuses for effects, previously these effect bonuses wouldn't be calculated until after projection calcs ran.
Drones can and often are in different stacks due to bandwidth and skills. The DNA would mess up in these cases because they would include duplicate ids with different numbers. This commit groups the drones by the itemID before generating the DNA. closes: pyfa-org#367
Mining Yield "per hour".
… into Ebag333-T3CSubRemoteRepEffect Conflicts: eos/effects/subsystembonusamarrdefensive2remotearmorrepairamount.py eos/effects/subsystembonuscaldaridefensive2remoteshieldtransporteramount.py eos/effects/subsystembonusgallentedefensive2remotearmorrepairamount.py eos/effects/subsystembonusminmatardefensive2remoteshieldtransporteramount.py
…a-export Groups drones before generating DNA
Except for 1 (clipboardXML), same number of lines of code in mainFrame, lots of code gone from fit, and no more complicated. Also spotted an import reference that got missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think if you merge this into yours, the PR will get updated.
At least, that's what I hope.