-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS Review #19
Comments
Thanks for the review 👍. I've commented on the first con in the JOSS review thread as it was brought up by multiple reviewers. Regarding the second point, I've added a sentence to clarify some of the packages' features; let me know if there's some particular detail you think should be added, I intended to describe the key functionality within that paragraph. I'll work on adding some benchmarks now; there's a small difficulty in reporting the metrics because the most interesting ones (NLL) have no other values to compare against (to my knowledge) because current benchmarks in materials science don't report uncertainty quantification metrics. |
The benchmarks are complete and I've reported the results for a few models with different hyperparameters in the appropriate results directory. |
Great! everything seems fine to me now. I have completed the checklist on the JOSS thread and will cross-post this comment there as well. |
Hi @a-ws-m! This will be an issue for my review for your JOSS submission.
Pros -
Cons -
Feel free to comment on these. I would be more than happy to discuss the same.
The text was updated successfully, but these errors were encountered: