Attribution of datadir fixture is insufficient

[pmeier]

The docstring currently only links to an StackOverflow answer:

unlockNN/tests/test_model.py

Line 34 in 128b192

Source: https://stackoverflow.com/a/29631801/

StackOverflow answers are published under the CC BY-SA 4.0 license, which requires more. Especially the ShareAlike part might be problematic, since unlockNN is distributed under the MIT license.

[a-ws-m]

Thanks for pointing that out, do you think it's sufficient to remove that line?

[pmeier]

That would make matters worse since in that you case you would outright plagiarize the code. I'm not experienced with the law side of things, so I won't make a recommendation. My impression is that it is (very) common practice in the industry to simply copy / paste code from other people, but scientific publications should be held to a higher standard here. cc @osorensen as editor of this JOSS review.

[osorensen]

@pmeier and @a-ws-m; I'm not immediately sure about this, so will hear with the editorial team and get back to you.

[osorensen]

@pmeier and @a-ws-m, having searched a bit, it seems to me like adding the link to the StackOverflow answer the way it is done here is appropriate. I am not a lawyer, but with regards to the standards of scientific publications, I think this is fine since the solution from StackOverflow is about testing the software, and not part of the core of the code.

[a-ws-m]

OK, I'll leave the citation there and close this issue. Thanks for checking this!