style: Fix unnecessary-comprehension-in-call (C419) (OSGeo#4027)

gui/wxpython/datacatalog/tree.py

@@ -2092,10 +2092,8 @@ def _popupMenuLayer(self):
 
         if not isinstance(self._giface, StandaloneGrassInterface):
             if all(
-                [
-                    each.data["name"] == genv["LOCATION_NAME"]
-                    for each in self.selected_location
-                ]
+                each.data["name"] == genv["LOCATION_NAME"]
+                for each in self.selected_location
             ):
                 if len(self.selected_layer) > 1:
                     item = wx.MenuItem(menu, wx.ID_ANY, _("&Display layers"))

lib/init/grass.py

@@ -1947,7 +1947,7 @@ def print_params(params):
 
     # check if we are dealing with parameters which require dev files
     dev_params = ["arch", "compiler", "build", "date"]
-    if any([param in dev_params for param in params]):
+    if any(param in dev_params for param in params):
         plat = gpath("include", "Make", "Platform.make")
         if not os.path.exists(plat):
             fatal(_("Please install the GRASS GIS development package"))

pyproject.toml

@@ -107,7 +107,6 @@ ignore = [
     "C405",    # unnecessary-literal-set
     "C414",    # unnecessary-double-cast-or-process
     "C416",    # unnecessary-comprehension
-    "C419",    # unnecessary-comprehension-in-call
     "COM812",  # missing-trailing-comma
     "COM818",  # trailing-comma-on-bare-tuple
     "D1",

python/grass/temporal/temporal_algebra.py

@@ -2249,7 +2249,7 @@ def build_condition_list(self, tvarexpr, thenlist, topolist=["EQUAL"]):
             # Use method eval_global_var to evaluate expression.
             resultlist = self.eval_global_var(tvarexpr, thenlist)
         # Check if a given list is a list of maps.
-        elif all([issubclass(type(ele), AbstractMapDataset) for ele in tvarexpr]):
+        elif all(issubclass(type(ele), AbstractMapDataset) for ele in tvarexpr):
             # Use method eval_map_list to evaluate map_list in comparison to thenlist.
             resultlist = self.eval_map_list(tvarexpr, thenlist, topolist)
         elif len(tvarexpr) % 2 != 0:
@@ -2259,12 +2259,12 @@ def build_condition_list(self, tvarexpr, thenlist, topolist=["EQUAL"]):
                 expr = tvarexpr[iter]
                 operator = tvarexpr[iter + 1]
                 relexpr = tvarexpr[iter + 2]
-                if all([issubclass(type(ele), list) for ele in [expr, relexpr]]):
+                if all(issubclass(type(ele), list) for ele in [expr, relexpr]):
                     resultlist = self.build_spatio_temporal_topology_list(expr, relexpr)
             # Loop through the list, search for map lists or global variables.
             for expr in tvarexpr:
                 if isinstance(expr, list):
-                    if all([issubclass(type(ele), AbstractMapDataset) for ele in expr]):
+                    if all(issubclass(type(ele), AbstractMapDataset) for ele in expr):
                         # Use method eval_map_list to evaluate map_list
                         resultlist = self.eval_map_list(expr, thenlist, topolist)
                     else:
@@ -2274,7 +2274,7 @@ def build_condition_list(self, tvarexpr, thenlist, topolist=["EQUAL"]):
                 elif isinstance(expr, GlobalTemporalVar):
                     # Use according functions for different global variable types.
                     if expr.get_type() == "operator":
-                        if all(["condition_value" in dir(map_i) for map_i in thenlist]):
+                        if all("condition_value" in dir(map_i) for map_i in thenlist):
                             # Add operator string to the condition list.
                             [
                                 map_i.condition_value.extend(expr.get_type_value())

scripts/d.polar/d.polar.py

@@ -510,7 +510,7 @@ def main():
     occurrences = sorted([(math.radians(x), freq[x]) for x in freq])
 
     # find the maximum value
-    maxradius = max([f for a, f in occurrences])
+    maxradius = max(f for a, f in occurrences)
 
     # now do cos() sin()
     sine_cosine = [(math.cos(a) * f, math.sin(a) * f) for a, f in occurrences]