-
Notifications
You must be signed in to change notification settings - Fork 68
Allow a range of package:web dependencies #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 696b254.
But why?This would help us smoothly land the following PRs in order:
I had to do something similar with my js-interop package for GIS, see here: @a14n is there any problem that I'm not seeing by maintaining the >=0.5.1 <2.0.0 range? It seems I didn't need any code changes in the JS-interop code itself, only in the examples (that are assuming 1.0.0 already) |
|
If we go back to
That's why I changed that. But if it makes your migration easier I can publish a temporary version. I just don't want to have this kind of issue with the final release. |
|
8.0.0-dev.4 published |
But Why not make the I haven't looked deep at how examples work/are built in this package, but I can set |
|
Another way of supporting the old innerHTML behavior in |
|
I agree with examples being their own app if they cause issues |
|
Forget my concern about examples. It's fine. Let me know if I can publish a final version of 8.0.0. |
| scripts. | ||
| homepage: https://github.com/a14n/dart-google-maps | ||
| environment: | ||
| sdk: ^3.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized a small mistake in v8.0.0; in order for the package:web version bracket to work, this sdk dependency should be: sdk: ^3.3.0.
Requiring ^3.4.0 here is (almost) the same as doing web: ^1.0.0 (not really, but we really really don't need to advance the sdk to support web 0.5.1).
I'll try to create a mini PR ASAP. Sorry for the churn, the new version is working great (and in Wasm!)
Revert "bump to web:^1.0.0"
This reverts commit 696b254.