[Feature/#125] Enhance configuration management by using toml configuration file #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add toml package in dependencies * Fix typo from target-versions to target-version for black
* Import os and toml package to enable toml file operations * Add a new command line argument -f and --configure to specify the toml configuration file path * Implement 'load_configure_file' func to check the existence of the file and load it * Implement 'parse_configure_file' func integrates the loaded configuration from file into the existing args * Add usage example (halmos.toml) * Add pytest testcode to ensure working load_configure_file and parse_configure_file functions
|
thanks @pillip, this has been long requested! I'll take a detailed look tomorrow |
karmacoma-eth
approved these changes
May 23, 2024
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Jun 2, 2024
### 🕓 Changelog The PRs a16z/halmos#296 and a16z/halmos#298 have added support for configuration files in `halmos` (https://github.com/a16z/halmos). This PR refactors the configurations currently used inline via the CLI and moves them to the new configuration file `halmos.toml`, which is located in the `test/` subdirectory. I also rename the configuration file `echidna-config.yaml` to `echidna.yaml` and move it to the subdirectory `test/` as well. Eventually, I bump the submodules `FreshCryptoLib` (https://github.com/rdubois-crypto/FreshCryptoLib) and `properties` (https://github.com/crytic/properties) to the latest available commit. --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Type
Description
This PR introduces enhancements to the configuration management and parsing functionalities of the Halmos project, improving flexibility, usability, and testing robustness. Key changes include the integration of the TOML configuration logic(loading and parsing), fixing a typo in the Black configuration, and ensuring that new functionalities are thoroughly tested.
Related Issues
This PR resolves #125
Changes
Tests