Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wasm-timer with zduny-wasm-timer #290

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

orenyomtov
Copy link
Contributor

@orenyomtov orenyomtov commented Oct 24, 2023

This fixes the following error that happens when running helios-ts in a Web Worker environment:

telegram-cloud-photo-size-1-5023824917329718351-y

More information on the origin of the error:
tomaka/wasm-timer#12
(tldr: it was relying on the global window which doesn't exist in a Web Worker)

And this is the commit of zduny's fork that fixed it:
zduny/wasm-timer@31beb5c

This fixes running helis-ts in a webworker environment
Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit 4e221c1 into a16z:master Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants