Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary truncateOverflow subtable #592

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

benoitrazet
Copy link
Contributor

The truncateOverflow subtable always returns 0 with WORD_SIZE = 32 or 64 bits. All the calls to this subtable are eliminated.

benoitrazet and others added 2 commits February 20, 2025 11:38
The truncateOverflow subtable always returns 0 with
WORD_SIZE = 32 or 64 bits. All the calls to this subtable are
eliminated.
@jprider63
Copy link
Contributor

I added a link to the CI benchmark results in the README, but let me know if you don't want to include this.

Copy link
Collaborator

@moodlezoup moodlezoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@moodlezoup moodlezoup merged commit 9740195 into a16z:main Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants