On headers callback called twice #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunk (this is triggering on headers callback two times)
|
Hi HoneyryderChuck, thanks very much for the PR. 1.) As stated in the README, I'm currently no longer maintaining this project, it was transfered to the ruby http parser folks, as they were the primary (only?) users. (https://github.com/http-parser/http-parser.java) not sure if this is being maintained. 2.) In case you can't find anyone there to merge your fix, with the tiny provision that it would require a small test that demonstrates the problem and illustrates that your patch fixes it. Sorry about that & thanks again! Write |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The on_headers_complete callback is called twice for chucked requests.
tmm1/http_parser.rb#52 for more info and a demonstration.