Skip to content

fix: handle listTasks status wire strings #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hae02y wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: handle listTasks status wire strings #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2412926
fix(rest): handle listTasks status wire strings
hae02y Jan 8, 2026
6be6271
fix: valid status list is generated from enum to avoid drift
hae02y Jan 8, 2026
3da3b44
fix: handle listTasks status wire strings
hae02y Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion transport/rest/src/main/java/io/a2a/transport/rest/handler/RestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@

import java.time.Instant;
import java.time.format.DateTimeParseException;
import java.util.Arrays;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Executor;
import java.util.concurrent.Flow;
import java.util.logging.Level;
import java.util.logging.Logger;
import java.util.stream.Collectors;

import jakarta.enterprise.context.ApplicationScoped;
import jakarta.enterprise.inject.Instance;
Expand Down Expand Up @@ -208,7 +210,21 @@ public HTTPRestResponse listTasks(@Nullable String contextId, @Nullable String s
paramsBuilder.contextId(contextId);
}
if (status != null) {
paramsBuilder.status(TaskState.valueOf(status));
try {
paramsBuilder.status(TaskState.fromString(status));
} catch (IllegalArgumentException e) {
try {
paramsBuilder.status(TaskState.valueOf(status));
} catch (IllegalArgumentException valueOfError) {
String validStates = Arrays.stream(TaskState.values())
.map(TaskState::asString)
.collect(Collectors.joining(", "));
Map<String, Object> errorData = new HashMap<>();
errorData.put("parameter", "status");
errorData.put("reason", "Must be one of: " + validStates);
throw new InvalidParamsError(null, "Invalid params", errorData);
}
}
}
if (pageSize != null) {
paramsBuilder.pageSize(pageSize);
Expand Down
25 changes: 25 additions & 0 deletions transport/rest/src/test/java/io/a2a/transport/rest/handler/RestHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,31 @@ public void testGetTaskNotFound() {
Assertions.assertTrue(response.getBody().contains("TaskNotFoundError"));
}

@Test
public void testListTasksStatusWireString() {
RestHandler handler = new RestHandler(CARD, requestHandler, internalExecutor);
taskStore.save(MINIMAL_TASK);

RestHandler.HTTPRestResponse response = handler.listTasks(null, "submitted", null, null,
null, null, null, "", callContext);

Assertions.assertEquals(200, response.getStatusCode());
Assertions.assertEquals("application/json", response.getContentType());
Assertions.assertTrue(response.getBody().contains(MINIMAL_TASK.id()));
}

@Test
public void testListTasksInvalidStatus() {
RestHandler handler = new RestHandler(CARD, requestHandler, internalExecutor);

RestHandler.HTTPRestResponse response = handler.listTasks(null, "not-a-status", null, null,
null, null, null, "", callContext);

Assertions.assertEquals(422, response.getStatusCode());
Assertions.assertEquals("application/json", response.getContentType());
Assertions.assertTrue(response.getBody().contains("InvalidParamsError"));
}

@Test
public void testSendMessage() throws InvalidProtocolBufferException {
RestHandler handler = new RestHandler(CARD, requestHandler, internalExecutor);
Expand Down