Skip to content

fix: Why not set tenant to "" in ListTasksParams$Builder?#657

Merged
ehsavoie merged 1 commit intoa2aproject:mainfrom
ehsavoie:issue_653
Feb 17, 2026
Merged

fix: Why not set tenant to "" in ListTasksParams$Builder?#657
ehsavoie merged 1 commit intoa2aproject:mainfrom
ehsavoie:issue_653

Conversation

@ehsavoie
Copy link
Collaborator

ListTasksParams.Builder should set the tenant to "" when it is not defined.

Fixes #653 🦕

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the ListTasksParams builder by ensuring that the tenant parameter is gracefully handled when not explicitly provided. Instead of failing with a null pointer check, the builder now defaults the tenant value to an empty string, preventing potential runtime errors and improving the user experience for API consumers.

Highlights

  • Tenant Parameter Handling: Modified the ListTasksParams.Builder to set the tenant parameter to an empty string ("") if it is null, instead of relying on Assert.checkNotNullParam which would throw an exception.
Changelog
  • spec/src/main/java/io/a2a/spec/ListTasksParams.java
    • Updated the build() method in ListTasksParams.Builder to handle null values for the tenant parameter by defaulting to an empty string.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly modifies the ListTasksParams.Builder to default the tenant field to an empty string when it is not explicitly set. This makes the builder's behavior consistent with other constructors in the ListTasksParams class. I have added one suggestion to improve code consistency by using an existing utility method.

Copy link
Collaborator

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just wondering if we should use the util

Assert.checkNotNullParam("id", id),
Assert.checkNotNullParam("pushNotificationConfigId", pushNotificationConfigId),
Assert.checkNotNullParam("tenant", tenant));
tenant != null ? tenant : "");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it really is needed, but we have the io.a2a.util.Utils.defaultIfNull() util to help with this here and other places

ListTasksParams.Builder should set the tenant to "" when it is not
defined.

issue a2aproject#653

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@ehsavoie ehsavoie merged commit 4aa7107 into a2aproject:main Feb 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why not set tenant to "" in ListTasksParams$Builder?

3 participants