feat: Move the sendMessage with a MessageSendParams to the AbstractClient#665
Open
jmesnil wants to merge 1 commit intoa2aproject:mainfrom
Open
feat: Move the sendMessage with a MessageSendParams to the AbstractClient#665jmesnil wants to merge 1 commit intoa2aproject:mainfrom
jmesnil wants to merge 1 commit intoa2aproject:mainfrom
Conversation
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the sendMessage method that takes MessageSendParams by moving it to the AbstractClient and making it public. This change provides more control over message sending parameters. The implementation has been moved from a private method in the Client class to an override of the new abstract method. The changes look good and achieve the stated goal. I have a couple of suggestions to improve code consistency and robustness.
…ient and made it public. Thought it might not be widely used, it allows full control of the parameters sent by the request (including the tenant). This fixes a2aproject#663 Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
jmesnil
force-pushed
the
663_SendMessage_with_params
branch
from
8b7e51e to
8c34bf5
Compare
ehsavoie
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and made it public.
Thought it might not be widely used, it allows full control of the parameters sent by the request (including the tenant).
This fixes #663