feat: server side support for extensions#171
Merged
guglielmo-san merged 88 commits intoa2aproject:mainfrom Nov 17, 2025
Merged
Conversation
fix: Implement ci for tck
feat: Implement ci for tck
ishymko
reviewed
Nov 14, 2025
guglielmo-san
changed the title
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully implements the server-side support for extensions, which is a great new feature. The implementation is well-structured, using a decorator pattern for the sample extension which makes the logic clean and easy to follow. The changes to propagate the ServerCallContext through the request handling pipeline are done correctly. The addition of tests for the new functionality is also appreciated.
I have two main points of feedback:
- A potential null reference issue in the sample
TimeStampExtensionwhich could lead to runtime errors. - An incorrect value in the
curlcommand example in the newREADME.md, which would prevent the sample extension from working as described.
Addressing these points will improve the robustness and correctness of the sample implementation. Overall, this is a solid contribution.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ishymko
changed the title
ishymko
approved these changes
Nov 17, 2025
4 tasks
guglielmo-san
added a commit
that referenced
this pull request
Nov 27, 2025
…ontext is created (#200) # Description This PR is a fix for the bug caused by the user being deleted when the request is containing requested extensions, as a new ServerCallContext was created without copying the `context.user`. Fixes #199 🦕 PRs #171, #195 BEGIN_COMMIT_OVERRIDE refactor: Populate the ServerCallContext user param when a new ServerCallContext is created END_COMMIT_OVERRIDE
guglielmo-san
added a commit
to guglielmo-san/a2a-js
that referenced
this pull request
Nov 27, 2025
…ontext is created (a2aproject#200) This PR is a fix for the bug caused by the user being deleted when the request is containing requested extensions, as a new ServerCallContext was created without copying the `context.user`. Fixes a2aproject#199 🦕 PRs a2aproject#171, a2aproject#195 BEGIN_COMMIT_OVERRIDE refactor: Populate the ServerCallContext user param when a new ServerCallContext is created END_COMMIT_OVERRIDE
guglielmo-san
added a commit
to guglielmo-san/a2a-js
that referenced
this pull request
Nov 27, 2025
…ontext is created (a2aproject#200) This PR is a fix for the bug caused by the user being deleted when the request is containing requested extensions, as a new ServerCallContext was created without copying the `context.user`. Fixes a2aproject#199 🦕 PRs a2aproject#171, a2aproject#195 BEGIN_COMMIT_OVERRIDE refactor: Populate the ServerCallContext user param when a new ServerCallContext is created END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code submitted in the PR introduces the support for extensions on the server side.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.BEGIN_COMMIT_OVERRIDE
feat: server side support for extensions
END_COMMIT_OVERRIDE
Fixes #170 🦕