refactor: rename ClientFactory.createFromAgentCardUrl -> createFromUrl#242
refactor: rename ClientFactory.createFromAgentCardUrl -> createFromUrl#242
Conversation
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the clarity and usability of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request renames the createFromAgentCardUrl method to createFromUrl in src/client/factory.ts, updating its JSDoc with usage examples, and adjusts corresponding calls in test/client/factory.spec.ts. A review comment suggests removing a redundant await keyword from the return statement within the createFromUrl method to avoid an extra microtask and improve async code cleanliness.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description
createFromAgentCardUrlmay give a wrong impression that full URL has to be provided, rename and add examples.Not yet released,
AgentCardResolverand the method were added in #225.