Skip to content

refactor: rename ClientFactory.createFromAgentCardUrl -> createFromUrl#242

Merged
ishymko merged 2 commits intomainfrom
ishymko/client-factory-rename
Dec 9, 2025
Merged

refactor: rename ClientFactory.createFromAgentCardUrl -> createFromUrl#242
ishymko merged 2 commits intomainfrom
ishymko/client-factory-rename

Conversation

@ishymko
Copy link
Member

@ishymko ishymko commented Dec 9, 2025

Description

createFromAgentCardUrl may give a wrong impression that full URL has to be provided, rename and add examples.

Not yet released, AgentCardResolver and the method were added in #225.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the clarity and usability of the ClientFactory class by renaming a key method. The change aims to prevent confusion regarding URL input requirements, making the API more intuitive. Alongside the rename, comprehensive examples have been added to the method's documentation, and all relevant tests have been updated to maintain consistency and ensure proper functionality.

Highlights

  • Method Renaming: The createFromAgentCardUrl method in ClientFactory has been renamed to createFromUrl to provide a clearer indication of its expected URL parameters and prevent potential misunderstandings.
  • Documentation Enhancement: New JSDoc examples have been added to the createFromUrl method, illustrating various usage scenarios with different URL and path configurations.
  • Test Updates: Corresponding test cases in factory.spec.ts have been updated to reflect the new method name, ensuring continued test coverage and correctness.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request renames the createFromAgentCardUrl method to createFromUrl in src/client/factory.ts, updating its JSDoc with usage examples, and adjusts corresponding calls in test/client/factory.spec.ts. A review comment suggests removing a redundant await keyword from the return statement within the createFromUrl method to avoid an extra microtask and improve async code cleanliness.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ishymko ishymko enabled auto-merge (squash) December 9, 2025 16:12
@ishymko ishymko requested a review from guglielmo-san December 9, 2025 16:13
@ishymko ishymko merged commit 4ad73c1 into main Dec 9, 2025
6 checks passed
@ishymko ishymko deleted the ishymko/client-factory-rename branch December 9, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants