Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/bin/threads: Fix non-explicit casting that caused non-64bit builds to fail #247

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

bostjan
Copy link
Member

@bostjan bostjan commented Sep 20, 2022

(i.e. in 32-bit Debian Sid container)

@bostjan bostjan added this to the 2.5.1 milestone Sep 20, 2022
@bostjan bostjan self-assigned this Sep 20, 2022
@bostjan bostjan linked an issue Sep 20, 2022 that may be closed by this pull request
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@bostjan bostjan force-pushed the fix-32bit-builds branch 2 times, most recently from 69b70f2 to c998d6c Compare September 20, 2022 22:10
…lds to fail (i.e. in 32-bit Debian Sid container)
…hitectures for now)

This is added to catch any 32-bit-related issues. We (upstream) are generally not
using 32-bit architectures anymore, but downstream packagers still package software
for 32-bit platforms. Let's not make their job more difficult than it already is.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.9% 96.9% Coverage
0.0% 0.0% Duplication

@bostjan
Copy link
Member Author

bostjan commented Sep 28, 2022

Marcos was kind enough to test out the changes from this branch before the merge, and here are the successful results:
image

Src: https://buildd.debian.org/status/package.php?p=snoopy

@bostjan bostjan merged commit db468dd into a2o:master Sep 28, 2022
@bostjan bostjan deleted the fix-32bit-builds branch September 28, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Iron out cross compilation issues
1 participant